Buildinggadgets: Class Cast exception when opening material list

[P3rf3ctXZer0]

---

After deleting this template, please provide the following information:

• Forge version FML: MCP 9.42 Powered by Forge 14.23.5.2838 199
• Building Gadgets version BuildingGadgets-2.7.0.jar
• If the issue is a crash; An external link to the crash report https://gist.github.com/P3rf3ctXZer0/66d01c9daadd8faed0733c43ba719ca9
• How to reproduce the issue Open material list
• A screenshot, if applicable

[P3rf3ctXZer0]

Why the hell does the template ask for forge version ... if people actually give you the crash log it is included.

[MajorTuvok]

Could you please provide the Informations instead of linking a gist

[MajorTuvok]

That might be true but you have to go through that crash log just to find it...
Furthermore I'd request the log, not only the crash log in order to be able to see what you where doing

[P3rf3ctXZer0]

kay

[P3rf3ctXZer0]

latest.log

[P3rf3ctXZer0]

I miss the days when it was right click left click ... this new system is very touchy.

[MajorTuvok]

I wonder how that happened: you were able to open the MaterialList, even though you had air in your hand (accorsing to the class cast exception)...

[P3rf3ctXZer0]

no it opens and crashes as in I never actually see the materials

[MajorTuvok]

Thanks for the log :). What do you mean with touchy?

[MajorTuvok]

It opens, yes... But according to the crash you opened it on an ItemStack with AIR as it's Item, which confuses me. Aka on an empty stack.

[P3rf3ctXZer0]

You used to have 3 buttons - Anchor - Radial - and Distance.
The mode feels a way busier then before. It has 7 hotkeys and I cannot just look at blocks. Copy and paste materials in my inventory.

Does the information "I shift left clicked a tinkers block" before this have any relevance?"

[P3rf3ctXZer0]

While holding building gadget?

[P3rf3ctXZer0]

I tried to build using the way I used to know.

[MajorTuvok]

Ok, I just found something which should definitly not be like that: It checks for reference equality with ItemStack#EMPTY. Even though changing that to an isEmpty() check and validating instanceof ITemplate in this spot will fix this issue, it still hints that at some point the GUI is errornously opened with illegal Data...

[MajorTuvok]

@MichaelHillcox This should have the isEmpty check.

[MajorTuvok]

@P3rf3ctXZer0 am I correct that you attempted to open the MaterialList for something other then an ITemplate (Copy-Paste-Gadget or Template item)? (Which is not supposed to work - should not crash though)

[MajorTuvok]

Add the oversight label, because this comes down to a missing isEmpty() check.

[P3rf3ctXZer0]

Yeah I tried opening it up while holding building gadget. I don't even what you are asking at this point - help item "Building gadget" and clicked open materials. I was trying to build a seared brick wall I held sneak and clicked a seared brick but it said "invalid stack isairempty" then I figured maybe I had to manually select the block and I clicked meterial list hotkey and bam crash! I hope this helps.

[P3rf3ctXZer0]

I had 128 seared bricks in my inventory too.

[P3rf3ctXZer0]

Tried this method and tutorial https://www.youtube.com/watch?v=JS1Xx_kwQQ0

[MajorTuvok]

The MaterialList is meant to show the Materials required to build a Template or something directly on the Copy/Paste. It does not work for the other Gadgets.
The materiallist hotkey doesn't select a block... Sadly the turotial you linked is badly outdated, I guess Dire is going to make one for 3.0.0 (once it's released in a few days) which is very similiar to 2.7.0

[P3rf3ctXZer0]

Well you can see why I am confused then?

[MajorTuvok]

Yep.

[MajorTuvok]

In order to select a block shift left or right click (I always mix the 2) a block.

[P3rf3ctXZer0]

I will wait till the version that does not crash me comes out ... I don't want my players complaining ... just let me know when that crash cannot happen anymore.

[MajorTuvok]

Shift right click it is apperently. I linked you the wiki, even though it is quite incomplete, it says that :)

[P3rf3ctXZer0]

Something else that is relevant maybe is that server and client configs did not match.

[MajorTuvok]

That's not a Problem: as of 2.6.0 they are synced. The Server config overwrites the client config whilst being connected to said Server.

[MichaelHillcox]

So it needs a check? I'll have a look today. I'll fix it has push out a hotfix

[P3rf3ctXZer0]

mkay :D

[MichaelHillcox]

Updated and pending approval on curse forge. New version is 2.7.1