Build: Some builds are hanging when using the Algolia plugin

[ehmicky]

Some builds are hanging after both @netlify/build and the buildbot Bash script have exited. This problem was reported by @BodinSamuel (from Algolia).

Link to a build using a Algolia Build plugin

I do not think this is due to the plugin's child process hanging. Plugins child processes are terminated using:

https://github.com/netlify/build/blob/master/packages/build/src/plugins/spawn.js#L86-L97

And I do not expect any problems in that specific piece of logic. My best guess is that this might be connected to the new deploy flow related to onSuccess.

[bodinsamuel]

Can we provide any other details to help?

[ehmicky]

The build logs should contain all the information. However, if you have links to the build logs of other sites experiencing the same issue, this might help. Thanks for asking!

[ehmicky]

From the build logs, it appears that the Deploy core plugin is not being called, even though this build is using the Algolia Build plugin. I suspect this might be the problem.

I am wondering if this is due to https://github.com/netlify/buildbot/pull/1006. The problem appeared right around the time this PR was released to production. This might have cancelled https://github.com/netlify/buildbot/pull/998. @kitop

[ehmicky]

Ongoing PR to fix this at https://github.com/netlify/buildbot/pull/1013

[ehmicky]

Fixed!

[bodinsamuel]

Thanks <3