Browser-laptop: Private Tabs with Tor feature needs to be labeled as beta

[davidtemkin]

Test plan

New private tab page should match this spec:

Original issue details

On the new private tab screen, the "Make this tab much more private with Tor" feature needs to be visually labeled as "beta" prior to the release of 0.23.x. A possible model for this is how Sync preferences are now labeled.

[rossmoody]

@bradleyrichter @davidtemkin How do we feel about this solve? If it's a go, I can very quickly hop in there and replace this svg.

[davidtemkin]

I like the treatment. It may be somewhat easy to miss because of color (e.g. I had to look for it for a second); what do you think? We don't need to scream "DON'T USE THIS" but it should be visible enough.

[rossmoody]

I agree. Black? Still sits in the illustration but more prominent.

[davidtemkin]

Works for me. @bradleyrichter ?

[bradleyrichter]

It works but adding it to the title string would add to it's recognition. If we don't need that much, then let's call it done.

[rossmoody]

Like this?

[bradleyrichter]

@rossmoody Probably on the right end instead?

[rossmoody]

[bradleyrichter]

Seems like the best placement to me. It can serve as the first use and be applied later for subsequent Beta functionality.

On Jun 25, 2018, at 1:30 PM, Ross Moody [e-mail] wrote:

https://user-images.githubusercontent.com/29072694/41874159-e944c04c-787b-11e8-9c7c-7847016fbdc5.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/brave/browser-laptop/issues/14541#issuecomment-400085179, or mute the thread https://github.com/notifications/unsubscribe-auth/AM4jqpHd6boJFAhyAQsQ5boMb2L92837ks5uAUhqgaJpZM4U2UZw.

[petemill]

ok I'll get it in

[NumDeP]

Are these images just a simple mock-up like paint and not Brave's actual UI model? I only ask because it will bug me a lot not seeing that toggle aligned with DDG's toggle :)

[bradleyrichter]

@petemill will make sure they are in alignment . : )

[rossmoody]

Sharp eye, these were quick mockups in sketch from a dated file. The toggles will align

[bsclifton]

Fixed with https://github.com/brave/browser-laptop/pull/14555

[btlechowski]

Verified on Ubuntu 17.10 x64

• 0.23.18 - c101002980044695e3e4291cf798e456f4d38dbf
• Muon - 7.1.2
• libchromiumcontent - 67.0.3396.87

Verified on Windows 10 x64
• 0.23.18 c101002980044695e3e4291cf798e456f4d38dbf
• Muon 7.1.2
• libchromiumcontent: 67.0.3396.87

Verified with macOS 10.12.6 using

• 0.23.18 c101002
• Muon 7.1.2
• libchromiumcontent 67.0.3396.87