Browser-laptop: Browser becomes inactive with get property error

Created on 28 May 2018 · 10Comments · Source: brave/browser-laptop

Description

Browser becomes unresponsive with get property error

Test plan / Steps to Reproduce

Visit goatdee.net
Click on any link that is listed on the page, opens up in the same tab
Wait till the ad countdown finishes
Click on the close advertisment button a new tab opens. You may be able to close it
Click on Install Flash link, another tab opens in background and browser becomes unresponsive
Context menu doesn't work, cant open a new tab, cant close any tabs, only way is to restart the browser

Actual result:
Browser becomes inactive. Unable to open new tab or switch tab. Browser console shows this error

Expected result:
Browser should be active

Reproduces how often:
100%

Brave Version

about:brave info:

Reproducible on current live release:
Yes

Additional Information

cc: @btlechowski @kjozwiak @LaurenWags to keep an eye on this on mac/Linux
Edit: found steps and updated the issue
cc: @bsclifton

0.22.x Qchecked-Linux Qchecked-Win64 Qchecked-macOS Qtest-plan-specified bug needs-investigation release-noteinclude

Source

srirambv

All 10 comments

Reproduced on Ubuntu 17.10 v0.22.721

The browser becomes unresponsive after step 4.

btlechowski on 28 May 2018

👍1

Reproducible under macOS 10.13.4 as well using the STR @srirambv mentioned above.

0.22.721 bfe7cdd - Reproducible using the above STR
0.22.714 fa2fbca - Reproducible using the above STR
0.22.669 6cda2e8 - Couldn't reproduce the issue using the above STR

Seems like it regressed somewhere between 0.22.669 & 0.22.714. @bsclifton even though it's not a recent regression, can we investigate and see if we could add this into the next release? Maybe the C67 release? It's a pretty bad issue where it renders the entire browser unusable.

kjozwiak on 28 May 2018

👍1

@kjozwiak SGTM 👍

bsclifton on 29 May 2018

This is a pretty crazy issue- great find/STR, @srirambv!

Here's what I'm seeing after doing some investigating:

ad countdown happens
click the X to hide the ad banner; new tab opens
sometimes I need to go back to the original tab and click where the countdown was
problem happens: over 90 tabs are created! this includes web contents, etc. I suspect these are popups
during the web contents add, the code exits out:
https://github.com/brave/browser-laptop/blob/9b102d8312cba7dca2d5f947936ce22dd37d2e0c/app/browser/tabs.js#L464-L467
web contents still exists but there is no frame associated with this
frameStateUtil.findNonPinnedDisplayIndexForTabId gets fired somehow for this web contents / tab (which doesn't have a frame) and causes the reported console error pictured. Specifically, the object is undefined (and not an Immutable object containing frame data) so there is no get method

bsclifton on 31 May 2018

@srirambv - "Click on any link which opens in a new tab" - please be very specific in the instructions. I don't know which links open in a new tab so now I'm just trying to click through a bunch of them.

bridiver on 31 May 2018

@bridiver updated the steps. All links listed on the page does the same hence mentioned as Click on any link

srirambv on 31 May 2018

I pushed a fix for this to C67, but I recommend that anyone trying to repro this use a vm snapshot. This site is loaded with malware.

bridiver on 31 May 2018

@srirambv I was confused because none of the links opened in a new tab, but in general I think it's best to specify a specific link so there is no ambiguity.

bridiver on 31 May 2018

Fixed with https://github.com/brave/muon/commit/117fe111a79b4ccb279874b85891040bac3d519d (needs verification when new Muon build available)

bsclifton on 31 May 2018

Verified on Windows x64 using