Browser-laptop: Error modal not properly covering all payment controls
Description
When you receive the corrupted seed modal, you'll notice that the Show only included sites isn't fully covered and can still be used. The modal should be covering the entire area and not give the user the ability to use any controls until the seed is restored.
Steps to Reproduce
- Run through the STR included in #14001
Actual result:
Scenario 1 :
Scenario 2:
Expected result:
Show only included sites shouldn't be visible when the corrupted seen modal is visible.
Reproduces how often:
100% reproducible using the above STR.
Brave Version
about:brave info:
Brave: 0.22.703
V8: 6.6.346.26
rev: 903b8d0d3703b5fdc5a719294403e7460d9b806d
Muon: 6.0.8
OS Release: 17.4.0
Update Channel: Beta
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 66.0.3359.13
Reproducible on current live release:
N/A, the corrupted seed modal regressed in 0.22.669.
Additional Information
kjozwiak
All 4 comments
Happens on this as well
srirambv
on 8 May 2018
What's strange is that now it's not even getting close to covering Show only included sites as it did before despite using 0.22.703 which was used in the original issue...
kjozwiak
on 8 May 2018
@kjozwiak Show only included sites should not be covered with this alert
NejcZdovc
on 9 May 2018
Pushing this back into 0.23 as fix made is #14067 will not cover all the cases, we need to create more general solution
NejcZdovc
on 9 May 2018
Related issues
bsclifton
路
3Comments
briannyeko
路
3Comments
antiroyalty
路
3Comments
bbondy
路
3Comments
bsclifton
路
3Comments
Most helpful comment
Pushing this back into 0.23 as fix made is #14067 will not cover all the cases, we need to create more general solution