Browser-laptop: 'Include site in Brave Payments' not available for bookmarks without http/https

Created on 2 May 2018 · 3Comments · Source: brave/browser-laptop

Description

If a bookmark doesn't have http or https in the URL (Location), then the option to 'Include Site in Brave Payments' does not appear on the context menu

Steps to Reproduce

Clean install 0.22.701
Enable payments, visit a couple of sites so you have some data in your ledger table.
Open about:bookmarks.
Click on the star+ icon.
Enter title and location (be sure to include http or https as appropriate) and save.
Right click on the newly added bookmark, you will see the 'Include in Brave Payments' option.
Click on the star+ icon.
Enter title and location (do not include http or https this time) and save.
Right click on the newly added bookmark.

Actual result:
'Include in Brave Payments' option does not display:
screen shot 2018-05-02 at 4 29 12 pm

Expected result:
Include in Brave Payments option should display as it does when you have http or https
screen shot 2018-05-02 at 4 29 24 pm

Reproduces how often:
easily

Brave Version

Reproducible on current live release:
n/a

Additional Information

Found while testing https://github.com/brave/browser-laptop/issues/6547
Reproduced on Win by @srirambv

featurrewards suggestion wontfix

Source

LaurenWags

Most helpful comment

discussed with @ryanml in slack and we decided to remove the context menu item when the bookmark doesn't have a protocol because the ledger info key requires a protocol. i guess the importance of this depends on how many users enter a URL without a protocol as a bookmark.

diracdeltas on 2 May 2018

👍3

All 3 comments

diracdeltas on 2 May 2018

👍3

Per comment from @diracdeltas, I'm going to remove the milestone from this issue. Unfortunately, there isn't a clean way to solve this without resolving the bookmark