Browser-laptop: Brave Shows Different Shortcuts for New Session Tab

[eljuno]

Description

Brave shows different shortcuts for creating session tabs. The shortcut previously added in #10363. See screenshot :)

Test plan / Steps to Reproduce

1. Right click + button on tabs bar > New Session Tab
2. Shortcuts shows Ctrl+1 etc. for session tab. This shortcuts used for navigating between tabs.
3. Open File menu (press alt if menu hidden) > New Session Tab
4. Shortcuts shows Ctrl+Alt+1 etc. This one is the expected shortcuts.

Actual result:

Expected result:
Should show the right shortcuts

Reproduces how often:
100%

Brave Version

about:brave info:

Brave | 0.20.30
-- | --
V8 | 6.4.388.40
rev | 8b78402
Muon | 4.7.9
OS Release | 6.3.9600
Update Channel | Release
OS Architecture | x64
OS Platform | Microsoft Windows
Node.js | 7.9.0
Brave Sync | v1.4.2
libchromiumcontent | 64.0.3282.119

Reproducible on current live release:
Yes

Additional Information

cc @aekeus @bsclifton

[cndouglas]

Looks fine on macOS. May be Windows-only.

[srirambv]

I think that shortcut should be Ctrl+Shift+Number.

Also Ctrl+Number just switches the tab 1-9 and not create a session tab.

[vinicentus]

Notice that if #13015 passes, we'll need to change these again.
Edit: This would be fixed by #13015. The shortcut would be changed to Ctrl + Shift + 1 on Windows and Cmd + Shift + 1 on MacOS.

[bsclifton]

Fixed with https://github.com/brave/browser-laptop/pull/13042

[srirambv]

Seeing this on latest build (0.20.41)

[LaurenWags]

Verified keyboard shortcuts removed on MacOS:

[btlechowski]

Verified
Brave: 0.20.42 V8: 6.4.388.41 rev: 096c7cb3c75ebb518f72fc7d24bc2bbaedd50aed Muon: 4.8.2 OS Release: 4.13.0-21-generic Update Channel: Release OS Architecture: x64 OS Platform: Linux