Browser-laptop: Right click on tab does not display context menu

Created on 20 Dec 2017  路  7Comments  路  Source: brave/browser-laptop

Test plan

https://github.com/brave/browser-laptop/pull/12351#issue-283729993


Description

Right click on a tab does not produce the context menu.

Steps to Reproduce

  1. Clean profile using 0.20.8
  2. Open a tab, right click on tab.
  3. 3.

Actual result:
No context menu is displayed.

@kjozwiak saw this error in terminal: [51634:775:1220/162016.991127:ERROR:CONSOLE(12)] "Uncaught TypeError: Cannot read property 'size' of undefined", source: chrome://brave/Applications/Brave-Beta.app/Contents/Resources/app.asar/app/extensions/brave/gen/app.entry.js (12)

Expected result:
Context menu should be displayed, no error in terminal.

Reproduces how often:
Easily

Brave Version

about:brave info:
Brave | 0.20.8
V8 | 6.3.292.48
rev | 015a3db
Muon | 4.5.28

Reproducible on current live release:
no

Additional Information

  • Was working with 0.20.3, stopped working with 0.20.5
  • Reproducible with MacOS and Windows (@srirambv and @kjozwiak ) (Linux is unavailable atm)
  • The following steps can act as a workaround for getting the context menu to display:
  • Detatch a tab from window with multiple tabs
  • Reattach the tab
  • Right click on tab and context menu will work
0.20.x Qchecked-Linux Qchecked-Win64 Qchecked-macOS Qtest-plan-specified bug featurcontext-menu regression release-noteexclude releasblocking

All 7 comments

This appears to be a duplicate of issue #12203 . I suppose one or the other should be closed?

@sharmalay thanks for the heads up! 馃槃 I'll pull your issue into our next release.

@LaurenWags can you confirm this is a dupe? (if so, maybe we can close this in favor of the one @sharmalay is working on, https://github.com/brave/browser-laptop/issues/12203)

@bsclifton @sharmalay from the fix that @diracdeltas did it's a different issue.

it looks like the same issue to me

@bsclifton i already opened a PR for this issue

Error looks similar but its different. Here's the screengrab from Windows
tab-context

@srirambv it will show app.entry.js instead of the pre-minified filename if you're using a packaged build. so i think it's a duplicate as mentioned in https://github.com/brave/browser-laptop/issues/12203#issuecomment-353497774

Was this page helpful?
0 / 5 - 0 ratings

Related issues

octohedron picture octohedron  路  3Comments

mykkymk picture mykkymk  路  3Comments

jonathansampson picture jonathansampson  路  3Comments

briannyeko picture briannyeko  路  3Comments

jonathansampson picture jonathansampson  路  3Comments