Browser-laptop: Updates on Beta channel are not working

[jamesray1]

Test plan

1. Install an old beta version (ex: 0.20.14)
2. Launch Brave-Beta and check for updates
3. Confirm an update shows
4. Update/relaunch and confirm you're using latest beta build

Description

Check for updates, get a message beginning with "Oops! We were not able to update."

updateLog.log

Reproduces how often:
100%

Brave Version

Brave: 0.19.58
rev: fe749c59b743160c55fdad906c13c798c7141562
Muon: 4.5.4
libchromiumcontent: 62.0.3202.38
V8: 6.2.414.23
Node.js: 7.9.0
Update Channel: Beta
OS Platform: Microsoft Windows
OS Release: 10.0.15063
OS Architecture: x64

Reproducible on current live release:
Not sure.

Additional Information

Brave also keeps crashing randomly without any apparent cause.

[jamesray1]

I went to brave.com and installed Brave, and now I have Brave 0.19.7, but the tab got frozen on that, so I think I'll need to use another browser.

[bsclifton]

@jamesray1 0.19.58 is a beta release and it may not have been a proper release either. Can you please download a stable channel release?
https://github.com/brave/browser-laptop/releases/tag/v0.19.80dev

[bsclifton]

OK I did verify that 0.19.58 was an actual Beta release- this can be seen here:
https://github.com/brave/vault-updater/blob/caf263b43ac469ba6b27352387ef39a32c1a34b3/data/beta/winx64.json#L24-L28

@aekeus any ideas on why the update would fail?

[jamesray1]

If I ran the install from brave.com, shouldn't this install the latest stable release? When I ran the install it installed 0.19.7. I'll try that again tomorrow as I may have used an older installation file with the same filename. If it doesn't install the latest release (0.19.80) I'll try downloading and installing that. Also it appears that Brave on Linux has updated automatically to 0.19.80, which is good.

[bsclifton]

@jamesray1 I just tried right now with Windows and the download link on Brave.com is for 0.19.80, as expected. Are you running a cache/proxy at your house (like squid?)

The link on Brave.com is to:
https://laptop-updates.brave.com/latest/winx64

[bsclifton]

Regarding 0.19.58 (Beta) not able to upgrade, there is an actual issue with our beta releases at the moment. The binaries were not properly uploaded to S3. I'll be investigating this issue

[jamesray1]

I downloaded and installed Brave 0.19.80 for Windows from brave.com. As I suspected I think I must have used an installation file that I downloaded from before.

[bsclifton]

Not actually fixed (yet)

The uploads done via Jenkins were fixed correctly with https://github.com/brave/release-tools/pull/2, but the service isn't taking Beta- in the filename into account. We'll need to update the server side on that one.

@aekeus can you help me look at this one? 😄

[jamesray1]

OK, keep up the good work, the browser keeps getting better and better! I love the open-source approach. It'll be great to try out the BAT. Indeed I see that it's available, so I'll try it out.

[bsclifton]

@aekeus when you're back from holiday, can you help me with this one? 😄

[srirambv]