Browser-laptop: Bookmark toolbar context menu not working on 0.20.x

[srirambv]

Test plan

See https://github.com/brave/browser-laptop/pull/12676

Description

Bookmark toolbar context menu not working on 0.20.x

Steps to Reproduce

1. Build from a42cac1
2. Add a bookmark to enable bookmark toolbar
3. Right click anywhere on the tool bar, does't show toolbar context menu instead shows window context menu

Actual result:

Expected result:
Should show bookmark toolbar context menu when right clicked on toolbar

Reproduces how often: [What percentage of the time does it reproduce?]
100%

Brave Version

about:brave info:

Brave | 0.20.1
-- | --
V8 | 6.2.414.36
rev | a42cac1
Muon | 4.5.11

Reproducible on current live release:
No

Additional Information

Found while verifying #11672

[NejcZdovc]

@srirambv if I am not mistaken this is on windows only right?

[srirambv]

Correct. Found on Windows, @LaurenWags @kjozwiak could verify for macOS

[kjozwiak]

Correct. Found on Windows, @LaurenWags @kjozwiak could verify for macOS

I couldn't reproduce this on either macOS nor Ubuntu... Went through the following checks:

• macOS 10.12.6 x64 on the 0.20.x branch using bafa261009eb51a451f8b7bceb7e39da543a1519 - Couldn't Reproduce
• Ubuntu 17.04 x64 on the 0.20.x branch using bafa261009eb51a451f8b7bceb7e39da543a1519 - Couldn't Reproduce
• Win 10 Pro x64 on the 0.20.x branch using bafa261009eb51a451f8b7bceb7e39da543a1519 - Reproduced

[bsclifton]

This has been reported many times already- it's a known issue, root cause captured with https://github.com/brave/browser-laptop/issues/4244

[srirambv]

@bsclifton this is a blocker on 0.20.8. Always shows system context menu on bookmark toolbar. Could #4244 be prioritized to 0.20.x so that it fixes the issue?

[bsclifton]

@srirambv this has been existing behavior for as long as we've switched to the version without titlebar (possibly earlier). Are you positive you're not seeing it with 0.19.x?

[srirambv]

Doesn't happen on the release build

I remember it got fixed by some PR a long time back but haven't seen this happen on most recent releases as adding bookmark from toolbar is part of general regression test run so it would have been captured if it happened on 0.19.x

[bsclifton]

@srirambv thanks for confirming- this new release should work as good as the one before. Maybe a style update affected this. If the area is marked as draggable, it will cause that issue

@luixxiul can you help me look at the area in question? perhaps there was an unintentional regression

[srirambv]

Another interesting thing is if the toolbar doesn't have any items then right at the edge of the tabs bar the context menu shows up but once you add any item to the toolbar the context menu disappears

[srirambv]

Adding it back to 0.20.x as its blocking couple of other issue to be verified

[NejcZdovc]

yeah not just bookmarks but tabs as well, more info here #12590.

[bsclifton]

Likely same fix as https://github.com/brave/browser-laptop/issues/12590