Browser-laptop: printToPDF doesn't do anything

Created on 12 Oct 2017 · 12Comments · Source: brave/browser-laptop

This one doesn't have an easy STR because we only call it from the contribution statement.

OWindows Qchecked-Linux Qchecked-Win64 Qchecked-macOS Qtest-plan-specified bug cr62 regression release-noteinclude releasblocking

Source

bridiver

All 12 comments

@bridiver, we can use npm run add-simulated-payment-history to generated fake payment history.

darkdh on 12 Oct 2017

Verified using these steps:
Had a profile with 0.19.66 (packaged build) where payments were enabled, closed Brave.
Renamed profile to be brave-development.
Built 0.19.x from source.
Ran npm run add-simulated-payment-history.
Renamed brave-development back to brave.
Opened 0.19.66 (packaged build) again.
Went to about:preferences#payments.
Opened payment history and clicked on a link.
On the new tab that opened with the contribution statement, verified I was prompted to save my statement. Verified I could save a statement. Verified I could cancel saving a statement.

cc @bridiver @darkdh @kjozwiak for confirmation these steps are sufficient for testing.

LaurenWags on 25 Oct 2017

Verification fails on Windows
STR

Clean install 0.19.66 and enable payments and close the browser
Build from source and run npm run add-simulated-payments-history 50
Copied the ledger-state.json from %appdata%/brave-development to %appdata%/brave
Launch the browser, click on payment history button
Click on any entry, opens a new tab with the contribution statement
No save prompt shown for the contribution statement tab

srirambv on 25 Oct 2017

@bridiver @darkdh any steps that I missed?

srirambv on 25 Oct 2017

@LaurenWags, @srirambv you are both right.
I just verified printToPDF doesn't work on Windows.

darkdh on 25 Oct 2017

@kjozwiak confirmed save prompt shown on Linux. Seems to be still an issue only on Windows

cc: @darkdh

srirambv on 25 Oct 2017

I also confirmed it worked for me on Debian.

luixxiul on 26 Oct 2017

👍1

Moving to hotfix 3

bbondy on 26 Oct 2017

Moving to hotfix 4

bbondy on 31 Oct 2017

Works fine on 0.19.72 for Windows. Prompts save file option when opening the payment statement

srirambv on 1 Nov 2017

@LaurenWags, can you double check and make sure this is working on macOS? I want to make sure the new fix hasn't regressed the other platforms as well. I'll check on Ubuntu.