Browser-laptop: .google.com cookie mismatch after import

[darkdh]

Test plan

https://github.com/brave/browser-laptop/pull/11647#issue-267885634

---

Description

Import cookies from Chrome/Firefox will cause cookie mismatch error on google.com

Steps to Reproduce

1. Clean cookies on Chrome/Firefox and login in google account
2. Import cookies from Chrome/Firefox to Brave
3. Login google account on Brave

Actual result:

Expected result:
No cookie mismatch error
Reproduces how often: [What percentage of the time does it reproduce?]
100%

Brave Version

0.19.36
about:brave info:

Brave: 0.19.36
rev: d24779f2704b4eb6fd5e7b0502a9ff1227f616bb
Muon: 4.4.25
libchromiumcontent: 61.0.3163.100
V8: 6.1.534.41
Node.js: 7.9.0
Update Channel: Beta
OS Platform: macOS
OS Release: 16.7.0
OS Architecture: x64
Reproducible on current live release:

Yes

Additional Information

Opera has the same problem
related to #11356

[darkdh]

cc @bbondy

[kjozwiak]

Using the STR from https://github.com/brave/browser-laptop/issues/11401#issue-264003667, went through the following verification:

• macOS 10.12.6 x64 - (imported cookies from Chrome/Chromium/Firefox) - PASSED
• Win 10 x64 - (imported cookies from Chrome/Chromium/Firefox) - PASSED

[darkdh]

chrome doesn't actually work

[kjozwiak]

We'll need to go through both scenarios using Firefox and Chrome:

• Test Case 1 -> https://github.com/brave/browser-laptop/issues/11401#issue-264003667 (importing gmail cookies when none exists within Brave)
• Test Case 2 -> https://github.com/brave/browser-laptop/pull/11647#issue-267885634 (importing gmail cookies into Brave when a set of gmail cookies already exists)

Other cases that should also be checked (basically try importing cookies at different points):

• import cookies from another browser into brave during the password phase when logging into gmail
• import cookies from another browser into brave during the 2FA phase when logging into gmai

[LaurenWags]

So when testing this using the steps specified in https://github.com/brave/browser-laptop/pull/11647#issue-267885634 while importing from Firefox, no errors. However, after those I took an additional step to login to a different gmail account than what was used in steps 1&3 and got the cookie mismatch error. Should that scenario be covered by this issue or is it different? cc @darkdh @kjozwiak

STR:

1. Clear cookies on FF/Chrome, login to gmail account 1
2. Close FF/Chrome, Open Brave (clean profile)
3. Import cookies only from FF/Chrome
4. Navigate to mail.google.com --> you are logged in with gmail account 1
5. Import cookies from FF/Chrome again, refresh gmail page (no errors display)
6. Logout gmail account 1. Login with gmail account 2 --> cookie mismatch error

[srirambv]

I get cookie mismatch error when I reload the gmail tab before logging out. Also seeing error mention by @LaurenWags when logging into a different account

[jonathansampson]

+1 from Twitter: https://twitter.com/edmorrissey/status/924318224707137537

[tomasdev]

Having this issue not by importing. Simply sign into 2 or 3 different gmail accounts and it breaks. Perhaps the Block 3rd party should have a configurable list of domain exceptions.

[jonathansampson]

@tomasdev We're able to set exceptions, but aim to do so with caution. I am regularly signed into 2 GMail accounts (without any issue). Would you be available to hop on a Skype or Google Hangout call sometime? I'd love to see the problem first-hand.

[Hjohnson14]

Hi all,
I'm having this problem too. I've tried both clearing cookies on Chrome and then importing the data to Brave and allowing all cookies for Google on the site shield setting, but neither has worked. Is there another solution? Access to gmail is essential to my browser usage.

[tomasdev]

@Hjohnson14 what I did to fix it was Preferences » Shields » Cookie Control: Allow all cookies until there's an option to whitelist 3rd party cookies per domain

@jonathansampson absolutely! you can see my email in my GH profile (signed in)

[jonathansampson]

Thank you, @tomasdev. I'll email you shortly :)

[LaurenWags]

Verified on macOS 10.12.6 x64 using the following build:

• 0.22.7 https://github.com/brave/browser-laptop/commit/8bb7e77f69bca186429aafda4bc6ba4d82a5de47
• libchromiumcontent: 65.0.3325.181
• muon: 5.1.1

Verified on Windows 7 x64

• 0.22.7 8bb7e77f
• libchromiumcontent: 65.0.3325.181
• muon: 5.1.1

Verified on Mint 18.3 x64 using the following build:

• 0.22.11 56de94731aa2aa9ab398ed928f68488f3ea5c11a
• libchromiumcontent: 65.0.3325.181
• muon: 5.1.2

[mikeongit]

What worked for me was to navigate to google.com and deactivate the Brave Shield.
Deactivating it for accounts.google.com only didn't do the trick for me, you also have to explicitly deactivate for the google.com domain.

Next, I signed in and was able to access my mail without any trouble.

[walker2]

@mikeongit
Thanks, your solution worked.

[kjozwiak]

@mikeongit @walker2 were guys importing cookies from either Firefox or Chrome? Or did you run into this issue when migrating from the muon version of Brave (old)?

[mikeongit]

Heya,

I imported cookies from both, Firefox and Chrome.

[walker2]

@kjozwiak Yeah just imported everything from Firefox

[kjozwiak]

@mikeongit @walker2 the Brave muon version isn't being supported anymore. I would suggest switching to the new version of the browser which can be found here:

• https://brave.com/download (Download Link)
• https://github.com/brave/brave-browser/ (GitHub Page)

We also have a dev and beta channel which can be found here:

• https://brave.com/download-dev
• https://brave.com/download-beta