Browser-laptop: Brave freezes when opening tabs while a window is loading

[cndouglas]

• Did you search for similar issues before submitting this one?
  Yes.

• Describe the issue you encountered:
  Brave freezes if you try to open tabs when a window has not loaded.

• Platform (Win7, 8, 10? macOS? Linux distro?):
  macOS 10.12.x.

• Brave Version (revision SHA):
  0.18.29 (85f059d)

• Steps to reproduce:

  1. Open Brave.
  2. While the window is still loading (while it is completely white), rapidly press Cmd+T to open new tabs.

  Or macOS-only:

  1. Open Brave.
  2. Close the window without quitting Brave
  3. Rapidly press Cmd+T to open new tabs.

• Actual result:
  Brave freezes.

• Expected result:
  The tabs should be opened.

• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  Not sure.

• Is this an issue in the currently released version?
  Yes, 0.18.29.

• Can this issue be consistently reproduced?
  Almost all the time.

• Extra QA steps:
  1.
  2.
  3.

• Screenshot if needed:
  None.

• Any related issues:
  Might be related to one of the freezing issues.

[cndouglas]

Duplicate of #10749.

[bbondy]

I think this is different from #10749 so re-opening. I'm going to move this to 0.19.x and move #10749 to 0.20.x

[cndouglas]

Sounds good! Please remove the duplicate tag.

[NumDeP]

This issue has become too common of an occurrence and it seems its happening more regularly than before with fewer tabs than usual as well. The unresponsiveness was always an issue but the crashes weren't as regular as they have been recently, meaning before it either crashed because of a lot tabs were available and recently with fewer tabs or because the browser hadn't been refreshed in long while.

Strange thing is I can still access the contents within the page, essentially make the last viewed website function almost properly with the exception of the url bar as you can see from the gif. It seems as though I've just been locked out of the browser despite it probably working fine behind the scene.

[bsclifton]

@NumDeP good catch- this bug is crashing the UI and you can get the specific error message by pressing Shift + F8 to open the Browser developer tools and viewing the console tab (which should help us find the issue!)

If it happens again, a screenshot is appreciated 😄

[NumDeP]

Hi @bsclifton any particular part of the console you'd like me to highlight because its literally just occurred now. All I can see is the information in this screenshot.

[bsclifton]

@NumDeP thanks for capturing that- seems that no error is being logged ☹️ But it looks like @bbondy has found the root cause and fixed! Stay tuned