Browser-laptop: Bookmarks cannot be moved to Other Bookmarks folder

Created on 26 Jul 2017 · 14Comments · Source: brave/browser-laptop

Test Plan

See below

Describe the issue you encountered: Bookmarks cannot be moved to Other Bookmarks folder.

bug

In the gif the bookmark is moved to the last row inside Bookmarks Toolbar folder.

Platform (Win7, 8, 10? macOS? Linux distro?): Debian
Brave Version (revision SHA): 0.18.12
Steps to reproduce:
1. Bookmark a page
2. Open about:bookmarks
3. Drag and drop the bookmark to Other Bookmarks
Actual result: the bookmark is not moved to the folder
Expected result: the bookmark should be moved to the folder
Extra QA steps:
1.
2.
3.
Any related issues: #8024

Qchecked-Linux Qchecked-Win64 Qchecked-macOS Qtest-plan-specified bug featurabout-pages featurbookmarks release-noteinclude

Source

luixxiul

All 14 comments

Yes this is because we only allow 0+ (not -1) for parent folder id. I notice this as well while I was working on my PR as well

NejcZdovc on 26 Jul 2017

fyi it has been possible to do so when I opened https://github.com/brave/browser-laptop/issues/8024

luixxiul on 26 Jul 2017

yeah I think that this is a regression

NejcZdovc on 26 Jul 2017

+1 from community

Like the record, moving bookmarks from Bookmark Toolbar folder and it's subfolder to Other Bookmarks folder will move that bookmarks to Bookmark Toolbars folder not Other Bookmarks.

eljuno on 26 Jul 2017

Similarly with moving a folder to 'Other Bookmarks'.

ubuntuotherfolder

LaurenWags on 27 Jul 2017

+1
FWIW I am having this problem as well. The "Other Bookmarks" folder might as well not exist.

Brave: 0.18.23
rev: 36ae2ec06efed0057ae16351108bf4d4c10a7ab4
Muon: 4.3.10
libchromiumcontent: 60.0.3112.90
V8: 6.0.286.52
Node.js: 7.9.0
Update Channel: dev
OS Platform: Microsoft Windows
OS Release: 6.1.7601
OS Architecture: x64

johnstrasser on 17 Aug 2017

+1 on this issue. Cannot move a single bookmark into "Other Bookmarks."

Brave: 0.18.36
rev: 7ab85e97318fef041433b0c3d73b457205fae805
Muon: 4.3.22
libchromiumcontent: 61.0.3163.79
V8: 6.1.534.32
Node.js: 7.9.0
Update Channel: dev
OS Platform: Microsoft Windows
OS Release: 10.0.15063
OS Architecture: x64

Cavadus on 9 Oct 2017

@Cavadus this will be fixed in version 0.21.x

NejcZdovc on 9 Oct 2017

👍1

+1. Couldn't today. When I created a folder in Other Bookmarks, I could move bookmarks to that folder.

Brave: 0.19.80
rev: 7d07299a5d462d3c9ae32cfbfbe7296cc57c89b9
Muon: 4.5.13
libchromiumcontent: 62.0.3202.75
V8: 6.2.414.36
Node.js: 7.9.0
Update Channel: Release
OS Platform: Linux
OS Release: 4.13.0-17-generic
OS Architecture: x64

jamesray1 on 10 Nov 2017

@jamesray1 this was fixed in 0.20 version, so in the next major release

NejcZdovc on 10 Nov 2017

👍1

@NejcZdovc should this work when moving a folder to 'Other Bookmarks' (see https://github.com/brave/browser-laptop/issues/10157#issuecomment-318444002)? Because right now the folder you move disappears from Bookmark Manager but stays on the Toolbar:
10157