Browser-laptop: Windows only - Bookmarks toolbar - Bookmark hover targets are pushed down if there are no tabs below the folder

[alexwykoff]

• Did you search for similar issues before submitting this one?
  Yes

• Describe the issue you encountered:
  A user from support reported that the highlight effect did not work as expected if there wasn't a tab underneath the bookmark folder.

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Window

• Brave Version (revision SHA):
  0.15.310

• Steps to reproduce:

  1. Create quite a few bookmark folders and add bookmarks
  2. Check bookmark folders above a tab vs those which exist over no tab.
  3. Slowly hover over each option

• Actual result:
  The bookmark or sub-folder did not highlight for folders without tabs beneath them. (It was later discovered the targets were pushed down to the last couple pixels of each first bookmark entry in the expansion menu.

• Expected result:
  The bookmark or sub-folder should have a highlight style applied

• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  Yes

• Is this an issue in the currently released version?
  Yes

• Can this issue be consistently reproduced?
  Yes

• Extra QA steps:
  1.
  2.
  3.

• Screenshot if needed:

• Any related issues:

[xjmzx]

Have a somewhat similar problem since last update to 0.15.310 on MacOS.

Bookmarks can no longer be dragged, dropped. Only created or deleted.

OS: Sierra 10.12.5 (16F73)

[eljuno]

+1 from community

[eljuno]

+1 from community

[alexwykoff]

@alexwykoff try to repro this plz 😸

[eljuno]

+1 from community https://community.brave.com/t/unable-to-click-first-bookmark-in-a-folder-via-bookmark-bar/5803?u=eljuno

[NejcZdovc]

+3 from #10323

[eljuno]

+1 from community https://community.brave.com/t/favorite-bar-issue/5900?u=eljuno

[eljuno]

+1 from community https://community.brave.com/t/bug-report-bookmarks-not-being-selected/8656?u=eljuno

[luixxiul]

I suspect it is due to that the area is reserved for system context menu on Windows. @bsclifton might know well about that.

[bsclifton]

+1 from https://github.com/brave/browser-laptop/issues/12097#issuecomment-348804531

[jonathansampson]

This does appear to rely on the mouse being within the region of the tab/new-tab elements below:

Looks like it may be identical/related to https://github.com/brave/browser-laptop/issues/9436#issuecomment-323191622.

[jonathansampson]

The problem here is collision with _drag regions_. These do not respect z-index, and thus take-over the mouse anytime you enter a the coordinates of a drag-region. In the above example, the entire tabStrip is draggable. The tabs and new-tab button are not, which allows you to hover bookmarks while in their drag region.

One solution is to temporarily remove the .allowDragging class from .tabStripContainer when a bookmark menu is opened, and restore the class once the bookmark menu has closed.

<span class="tabStripContainer allowDragging">...</span>

[LaurenWags]

+1 from twitter: https://twitter.com/wwwmarty/status/944245295927394304

[eljuno]

+1 from community https://community.brave.com/t/first-favourite-website-in-a-folder-is-clickable-only-on-a-first-pixel/13328?u=eljuno

[srirambv]

+2 from community https://community.brave.com/t/bookmark-bug-unable-to-click-the-first-bookmark/13996/2

[eljuno]

+1 from community https://community.brave.com/t/bug-report-bookmark-bar-problem/13981?u=eljuno

[eljuno]

+1 from community https://community.brave.com/t/bookmark-folder/14350?u=eljuno
+1 from community https://community.brave.com/t/difficult-time-accessing-first-bookmark-within-bookmark-folders/14417?u=eljuno

[NejcZdovc]

I think that we need to bump priority on this one @bsclifton

[eljuno]

+1 from community https://community.brave.com/t/unclickable-bookmark-area/14652?u=eljuno

[NejcZdovc]

pulled into 0.21

[eljuno]

Can't reproduced on latest stable version 0.20.30

Record:

[jonathansampson]

@elia The dropdown needs to overlap the tab and new-tab button. See the positions of the UI elements in this comment: https://github.com/brave/browser-laptop/issues/9088#issuecomment-349021143

[NejcZdovc]

pushing back to 0.22

[eljuno]

@jonathansampson Still can't reproduce this on latest stable. 😄

[alexwykoff]

@bsclifton @jonathansampson feel free to close if no repro thx

[bsclifton]

Confirmed this works great using 0.21.18 on Windows 10 x64 😄 👍