Browser-laptop: Tab loading bugs on npm run watch && npm start

[luixxiul]

Describe the issue you encountered: Tab loading bugs on npm run watch && npm start.

• Platform (Win7, 8, 10? macOS? Linux distro?): macOS

• Brave Version (revision SHA): 1c04c53

• Steps to reproduce:

  1. git checkout master && git fetch upstream && git rebase upstream/master
  2. rm -rf node_modules && rm -rf ~/.electron && npm i
  3. npm run watch
  4. npm start
  5. Click the twitter icon
  6. Change source code to fire auto reload

• Actual result:

  • [ ] Two blank tabs are loaded
  • [ ] If you click twitter tab icon again, both tabs load twitter
  • [ ] If you open the 1st tab, the tab is blank
  • [ ] There is no lock icon on the 2nd tab
    
    

• Expected result: None of them should not happen

• Extra QA steps:
  1.
  2.
  3.

• Any related issues:

[luixxiul]

Also the tab is duplicated each time when you edit and save files. ie when you edit and save 4 times, other 4 new tabs are opened

If you click the tile on one tab, the rest of the tabs also open the same page.

[NejcZdovc]

I noticed this bug for the first time when we merged tear off tabs

[luixxiul]

this bug is so annoying that devs would lose concentration. I think this should be fixed soon.

[luixxiul]

I'm not sure why this is low impact.. I've been struggling with the issue while I'm coding the compact bravery panel.

[bsclifton]

@luixxiul in the triage meeting the reasons we gave were:

• it only affects devs (not users)
• there is a work-around: (you can always quit / relaunch the browser process (watcher seems fine))

It definitely needs to be fixed though 😄

[luixxiul]

I see!

[bsclifton]

This is working great for me! 😄 So happy to be able to have webpack recompile/reload while editing. Fixed with https://github.com/brave/browser-laptop/pull/9328

@luixxiul I'll leave it to you to try it out and will assign to this milestone 😄

[luixxiul]

Maybe I'll need new Muon. I'm going to try my STR later (because I'm on the poor connection now)

[luixxiul]

uhm I still see the same issue on macOS. Every time the browser is reloaded, another new tab is opened.

[luixxiul]

maybe because I'm on 0.15.312 as https://github.com/brave/browser-laptop/issues/9097#issuecomment-307148003 ?

[bsclifton]

@luixxiul maybe I tried the wrong steps to reproduce. I was assuming (perhaps wrongly) that this was happening when a file is edited (ex: when reload happens, things break). I did fix that scenario, perhaps this is something different

[bbondy]

Please try with master and if it works then you can close this. Thanks @luixxiul

[bsclifton]

@luixxiul I see that you mention it's not fixed in https://github.com/brave/browser-laptop/pull/9328#issuecomment-307006823

I am not able to reproduce the issue where saving / reloading creates more tabs. Can you edit the original post with more details about what you're seeing? Thanks 😄

[NejcZdovc]

For me it's really easy to reproduce.

1) run npm run watch and npm run start
2) open dev tools
3) modify a component
4) tabs are duplicated

[NejcZdovc]

One thing that also happens for me is that if you have for example 3 tabs opened and brave is reloaded with webpack when you click on + (add new tab) 3 tabs will be opened and not 1.

[jonathansampson]

The phantom tabs are apparently interrelated.

[NejcZdovc]

Yes, we display them as 3 for example but in the end is only one. I checked and we actually have this in the state as well. If I try to close phantom tab as soon as webpack reloads the whole window crashes.

[luixxiul]

I haven't seen the issue recently. Closing.