https://github.com/brave/browser-laptop/pull/9867#issue-240628027
Describe the issue you encountered:
Downloading the same name file disabling the save file dialog should change the filename, like Edge does. For now the file is overwritten, which users do not always want to see.
Platform (Win7, 8, 10? macOS? Linux distro?):
Brave Version (revision SHA): 0.14.0 Preview
Steps to reproduce:
Actual result: the file is overwritten
Expected result: the file should be saved with the filename changed, eg RELEASES-ia32(1)
Any related issues: #2110
Marking this with impact/high as the users could lose their files by accident because of this setting, which behaves slightly different than the other browsers.
I think that this should be handled on Muon part
cc @bridiver
I ran into this today. Please fix! This bug scares me.
Hey @luixxiul & @NejcZdovc, I just submitted a PR (#9867) for this issue
Hey @luixxiul & @NejcZdovc, I've updated the PR based on the feedback from @bridiver and added some tests as well....FYI
Most helpful comment
Hey @luixxiul & @NejcZdovc, I just submitted a PR (#9867) for this issue