Browser-laptop: Downloading the same name file disabling the save file dialog should change the filename

Created on 17 Mar 2017  路  5Comments  路  Source: brave/browser-laptop

Test plan

https://github.com/brave/browser-laptop/pull/9867#issue-240628027


Describe the issue you encountered:
Downloading the same name file disabling the save file dialog should change the filename, like Edge does. For now the file is overwritten, which users do not always want to see.

  • Platform (Win7, 8, 10? macOS? Linux distro?):

  • Brave Version (revision SHA): 0.14.0 Preview

  • Steps to reproduce:

    1. Open about:preferences
    2. Specify a download path
    3. Disable "Always ask me where to save files"
    4. Download a file of a release from https://github.com/brave/browser-laptop/releases (eg RELEASES-ia32 of the Preview3)
    5. Wait until the download ends
    6. Download another file which has the same name of a different version (eg RELEASES-ia32 of the Preview2)
  • Actual result: the file is overwritten

  • Expected result: the file should be saved with the filename changed, eg RELEASES-ia32(1)

  • Any related issues: #2110

Marking this with impact/high as the users could lose their files by accident because of this setting, which behaves slightly different than the other browsers.

Qchecked-Linux Qchecked-Win64 Qchecked-macOS Qtest-plan-specified featurdownload release-noteinclude

Most helpful comment

Hey @luixxiul & @NejcZdovc, I just submitted a PR (#9867) for this issue

All 5 comments

I think that this should be handled on Muon part

cc @bridiver

I ran into this today. Please fix! This bug scares me.

Hey @luixxiul & @NejcZdovc, I just submitted a PR (#9867) for this issue

Hey @luixxiul & @NejcZdovc, I've updated the PR based on the feedback from @bridiver and added some tests as well....FYI

Was this page helpful?
0 / 5 - 0 ratings

Related issues

eljuno picture eljuno  路  3Comments

octohedron picture octohedron  路  3Comments

lukemulks picture lukemulks  路  3Comments

luixxiul picture luixxiul  路  3Comments

bsclifton picture bsclifton  路  3Comments