Browser-laptop: Right clicking tab being previewed causes focus to change

[luixxiul]

Test plan

https://github.com/brave/browser-laptop/pull/9360#issue-234737199

1. Open two tabs. Set focus to tab 2
2. Right click tab 1 and verify context menu appears
3. Press ESC (if your keyboard has it 🤣 )
4. verify menu closes and focus did NOT change
5. Right click tab 1 so that context menu appears
6. Right click another place in tab 1 so that the context menu closes then reopens
7. Verify focus did NOT change
8. Push ESC and verify menu closes / focus did not change

[Jacalz]

Updated steps to reproduce

1. Open two tabs
2. Right click on the tab that isn´t in focus so the context menu apears
3. Press Esc, it switches to the tab that wasn´t in focus...
   

   Original description

• Did you search for similar issues before submitting this one?
  Yes
• Describe the issue you encountered:
  Having 2 or more tabs and hovering over the first tab and right clicking on it and then pressing "Escape" on the keyboard switches you to the tab you right clicked. https://community.brave.com/t/closed-right-click-bug-in-tab/1312
• Platform (Win7, 8, 10? macOS? Linux distro?):
  I was able to reproduce the issue on Windows 10 Pro on two different computers and on Windows 7 Professional on a fresh profile. It and this only seems to be a problem on windows because i could not reproduce it on any of my computers running MacOS. Linux i don´t know...
• Brave Version (revision SHA):
  0.13.4

• Steps to reproduce:

  1. Open 2 or more tabs with different websites (Doesent matter how many)
  2. Make sure you are in the second tab
  3. Hover over the first tab and right click on it
  4. Press "Esc" on your keyboard and you are sudenly on the first tab

• Actual result:
  You are on the tab you right clicked on.

• Expected result:
  You should remain on the tab you were on just that the right click menu should dissapear.
• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  Yes
• Is this an issue in the currently released version?
  Yes
• Can this issue be consistently reproduced?
  Yes

[bsclifton]

@Jacalz the issue is yours if you'd like it 😄 Let me know and I'll self-assign it (to reserve it)

[Jacalz]

Oh, I really didnt mean it the way i wrote it, thats why i removed the comment. :sweat: What I meant what that i should be able to edit the text not fix the issue :sweat_smile: But i can do without that :+1: I realised that assigned meant fixing it not having permission to edit the post :man_facepalming:

[bsclifton]

@Jacalz ah ok- no problem 😄 understood. Please do update the text to be as accurate and easy to understand as you'd like 😄 Thanks!

[bsclifton]

Closing as I can't reproduce on latest build. @Jacalz can you please retest to make sure I didn't misunderstand the steps?

[Jacalz]

Will see later today 😉

[Jacalz]

Still an issue: @bsclifton

1. Open two tabs
2. Right click on the tab that isn´t in focus so the context menu apears
3. Press Esc, it switches to the tab that wasn´t in focus...

[bsclifton]

@Jacalz are you on Windows? (asking because it works OK on macOS). I'm testing using the latest 0.15.3xx release

[Jacalz]

I am on Windows 10 and I tested on 0.15.303 because npm run watch fails on the latest master 😬