Browser-laptop: Extension Popup Sized, Positioned Incorrectly

[jonathansampson]

• Did you search for similar issues before submitting this one?
  Yes

• Describe the issue you encountered:
  The extension popup window may have the wrong size and location depending on the display scaling.

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows 10 (SurfaceBook, 200%)

• Brave Version (revision SHA):
  https://github.com/brave/browser-laptop/commit/50443ade90c70d2f3793020eb671c4c268947a71

• Steps to reproduce:

  1. Enable LastPass
  2. Click LastPass button in top bar
  3. Note location of popup window

• Actual result:
  Window is size and positioned incorrectly.

• Expected result:
  Window should be sized and positioned correctly.

• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  Yes

• Is this an issue in the currently released version?
  Yes

• Can this issue be consistently reproduced?
  Yes

• Screenshot if needed:
  

[josiah-keller]

I see a different but similar result - potentially the same issue? (150% scaling)

[jonathansampson]

@josiah-keller I think it's the same issue; I'm at home now, with my Surface Book docked. On my external display (which is at 100%), the popup is sized and positioned correctly. If I drag Brave to my Surface Book screen (which is at 200%), the popup is sized and positioned incorrectly.

[josiah-keller]

@jonathansampson Yep, same case with my 100% monitor.

[jonathansampson]

Adding --enable-use-zoom-for-dsf=false to my shortcut resolves the issue. Thanks, @bsclifton, for the tip.

[bbondy]

Moving to 0.13.3 since it's already a live problem, we're only blocking at this point on things that are critical or that make what's released worse, @bsclifton maybe you can see what's going on with DPI with extensions?

[srirambv]

One more report from community user on high resolution display
https://community.brave.com/t/lastpass-extension-unusable-on-high-res-screen/1101

[Dreae]

Chiming in, I'm having the same issue on a MBP running linux. Adding --enable-use-zoom-for-dsf=false did not solve the problem in my case. Brave version https://github.com/brave/browser-laptop/commit/71d8ffc7278a90b22b8617d37880787c1781e694 Problem is identical to @jonathansampson's screenshot for his 200% display.

[jonathansampson]

@Dreae, which version of Brave are you testing?

[Dreae]

@jonathansampson 0.13.4 - https://github.com/brave/browser-laptop/commit/71d8ffc7278a90b22b8617d37880787c1781e694 on linux

[jonathansampson]

@Dreae Would you be willing to clone/setup the browser-laptop project, and test a particular fix? I'm happy to walk you though the process if you'd like.

@josiah-keller Same question for you :)

[josiah-keller]

@jonathansampson Sure, but I just got a new machine so I'll get back to you in a few years after VS installs.

[jonathansampson]

@josiah-keller Happy to proceed whenever you're ready (and have confirmed that your new machine reproduces the issue observed here in this thread).

[stshank]

I'm experiencing this issue too on a Microsoft Surface Book, Windows 10. Clicking the LastPass icon pops up an unusable dialog box. I'm viewing the screen at 250% as configured in the Settings app.

[jonathansampson]

@stshank Can you test the advice given here: https://github.com/brave/browser-laptop/issues/7051#issuecomment-277420728?

[stshank]

@jonathansampson Will try. What's the path on Windows to find brave.exe?

[bsclifton]

@stshank sorry for the super long turn-around; the Brave executable is going to be at %userprofile%\AppData\Local\brave. You should be able to cheat and right click > properties on the shortcut also

[jonathansampson]

This issue is revealed via the new _Toolbar and UI elements scale_ setting.

[dotbloup]

Similar problem on Mac OS. except i see a transparent rectangle on the lower right corner after clicking on the extension icon from lastpass. rev: af7ef42

[trosel]

I need my monitor to be 150% in the windows display settings. Lastpass is unusable on Brave when at 150%.

Thus, I sadly cannot use Brave :(

[trosel]

@jonathansampson When selecting large or supersize for the UI elements, the lastpass white box gets MASSIVE but the actual lastpass content stays exactly the same size.

[bsclifton]

Also affects Metamask and bitwarden:

[bsclifton]

This should be fixed with brave-core (would be good to verify- cc: @jonathansampson