Browser-laptop: Multiple home page URLs stopped working - "Your file was not found"

[JeffStarr]

This worked great before the last update. Here is an example of the syntax that worked before:

file:///start.html||https://start.duckduckgo.com/|https://google.com/|https://bing.com/|...

That syntax is common way to specify multiple home page tabs in browsers.

Suddenly it stopped working in version 0.13.0; no home tabs load, only an error tab that says:

Your file was not found
It may have been moved or deleted.
ERR_FILE_NOT_FOUND

Hopefully you can get this fixed soon. I want to continue using Brave, but need that multiple-tab startup or it's a deal-breaker. Thanks again for a great browser.

3110

Test plan

https://github.com/brave/browser-laptop/pull/6922#issue-203979259

[JeffStarr]

Updated to add that the error is different depending on the URLs specified in the "My home page is" setting. If the setting (using vertical pipes to specify multiple URLs) begins with a local file, the "Your file was not found" error is displayed. Otherwise, if the setting begins with an HTTP address, like https://google.com, then the error isn't displayed, but only one tab loads up the entire URL, for example:

https://start.duckduckgo.com/|https://google.com/|https://bing.com/|...

..which leads to crazy undesirable results.

Either case, the setting worked great before 0.13.0.

[cndouglas]

I can reproduce with 0.13.0 on macOS 10.12.x. I think the pipe | is being encoded as part of the URL.

[cndouglas]

@bsclifton Could this have been caused by #6086?

Also, do we have any automated tests for multiple home pages?

[bsclifton]

@Liunkae no, I don't believe it was caused with that. If I had to guess, I would think maybe it was caused by the encodeURI in https://github.com/brave/browser-laptop/pull/6404

cc: @NejcZdovc

[NejcZdovc]

@bsclifton I tried locally reverting this commit and #6404 is not a cause for this problem. This commit/function is executed only on event drop.

[bsclifton]

Thanks for checking that out, @NejcZdovc! 😄

We'll need to investigate further to determine what changed. It's important to note that we never explicitly enabled this functionality (it just "worked"). The feature itself is captured with https://github.com/brave/browser-laptop/issues/3110

[NejcZdovc]

And a side note, this is not related to the file in the url, same problem occure if you use multiple pages

[srirambv]

@bsclifton @NejcZdovc here's what I found

1. Multiple home pages is not recognized and opened in individual tabs only on browser launch
2. Clicking on home button (with only web links set) opens all the sites in individual tabs
3. If only a file is set as home page, clicking home button loads the file but doesn't load the file on browser launch
   4. Local file and web pages set as home page(like above), clicking on home button only loads the sites and not the local file

Also https prefix is not required, I just used the domain names separated with | and it worked

Edit: step 4 works, File is opened in the same tab where the home button is pressed

[srirambv]

"Your file was not found" error is displayed.

This shows only when the new tab is set to homepage. Like @Liunkae said | is parsed into %7C. But if the new tab is set to dashboard it loads the files and the sites

[NejcZdovc]

Will cover all scenarios that you listed above in #6922

[NejcZdovc]

@srirambv Can you please check out #6922 and test if everything is fine. The only thing missing there are tests, other then that should be done. Thank you

[srirambv]

@NejcZdovc verifed #6922 Works perfect as per the test plan mentioned. 👍