Browser-laptop: Building Brave on Windows causes generic Electron window to appear

Created on 31 Dec 2016  路  6Comments  路  Source: brave/browser-laptop

Did you search for similar issues before submitting this one?
Yes.

Describe the issue you encountered:
When you npm run watch && npm start on Windows it starts Brave but also opens the generic Electron window (screenshot below).

Expected behavior:
It should start Brave and not show the Electron window.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Win10

  • Brave Version (revision SHA):
    master

  • Steps to reproduce:

    1. Build Brave on Windows
    2. npm run watch-all && npm start
    3. notice two windows open, Brave and Electron.
  • Screenshot if needed:
    capture

  • Any related issues:

OWindows Qno-qa-needed release-noteexclude

Most helpful comment

Per @darkdh, this should have been fixed by https://github.com/brave/muon/commit/99dff2869cade76dbbec4aee51c5b68038a5622c :smile:

All 6 comments

This appears to be fixed as of https://github.com/brave/muon/commit/30fd6ff5ac772cb645b0d4be78fae49d84fbbb19. Once we have a new prebuilt, let's re-test :smile:

Closing this for now; I got latest in browser-laptop-bootstrap and it's no longer happening

Please remove the milestone and add labels QA/no qa needed and release-note/exclude if this appeared and was fixed within the same milestone, thanks!

@luixxiul labels updated; keeping milestone for tracking purposes

Per @darkdh, this should have been fixed by https://github.com/brave/muon/commit/99dff2869cade76dbbec4aee51c5b68038a5622c :smile:

Sweet!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jkup picture jkup  路  3Comments

bsclifton picture bsclifton  路  3Comments

jonathansampson picture jonathansampson  路  3Comments

jonathansampson picture jonathansampson  路  3Comments

bbondy picture bbondy  路  3Comments