Browser-laptop: Bookmark title on bookmark toolbar is renamed

[luixxiul]

Test plan

https://github.com/brave/browser-laptop/pull/10136#issue-245629798

---

Describe the issue you encountered:
Bookmark title on the bookmark toolbar is renamed after clicking the link to the notification page on GitHub.

Expected behavior:
The bookmark title should not be changed.

• Platform (Win7, 8, 10? macOS? Linux distro?): macOS

• Brave Version: master branch

• Steps to reproduce:

  1. Bookmark the notification page on GitHub
  2. Click the notification link -> the bookmark title is changed

• Screenshot if needed:
  

• Any related issues:

[luixxiul]

Edited.

[bsclifton]

This may or may not be expected. This is the current behavior:

• When a site is visited, a siteDetail record will be created
• If one already exists, that will be updated
• The new title ALWAYS overwrites the old title. Custom title does not change
• If custom title is never set (which only happens if user manually does it), the user will always see the title (which will end up being the new one, OR if blank, the URL)

To keep things simple, I'd like to propose that we eliminate custom title.

• When a bookmark is added for a page, it will default to the title of the page
• Once set, the title for that bookmark will never be updated again

What do you think @luixxiul? Also, CC: @bradleyrichter @BrendanEich @bbondy @darkdh (and everyone else too :smile: )

[luixxiul]

When a bookmark is added for a page, it will default to the title of the page
Once set, the title for that bookmark will never be updated again

If this is the default behavior on Chrome/Firefox, +1 :)

[cndouglas]

+1 for your proposal. It seems like the least confusing option from a user perspective.

[NejcZdovc]

+1 When you are visiting a page that is also bookmarked, this should not change bookmark title. I would keep the same functionality for custom title as is now. Other browsers has the same functionality.

More problematic problem is that when you click on the same url on the page that you are already on, title is not rendered correctly. But if you click on this url in bookmark bar or refresh the page, title is rendered correctly. We can see this in @luixxiul screenshot.

[luixxiul]

@NejcZdovc I have reported the issue on #5738

[bsclifton]

@luixxiul would this be something you'd be interested in looking at? (I'd be more than happy to help!) I bet there are at least 2 or 3 more issues related to this same root cause. Let me know :smile:

[bradleyrichter]

@bsclifton I think the custom title is a requirement. Quite often, a page is bookmarked at an entry point to a top domain but the user wants to simply the BM title to be the top domain.

For example:

I wanted to rename this obscure title (when truncated) to 'CSS Tricks" which is far more recognizable/meaningful.

[bsclifton]

@bradleyrichter my proposal is to eliminate the custom title field and then use the regular title field like a custom title. Right now, the title is something that users can't change... but it causes problems because it will update if the page title updates. The user would have to go and explicitly set a title if they didn't want it to change

I think it's a better experience to always treat the title like it's a custom title. It should never be updated unless the person changes it themselves. That should be consistent with other browsers. What do you think?

[bradleyrichter]

Yes. Agree. I was confused about the meaning of Title and Custom Title. The user only sees title.

Under the hood, we should just treat a title as a custom title and never auto-update any BM data. Only if the user updates the data manually. (as you described)

[NejcZdovc]

If we remove CustomTitle then issue #6104 and PR #6111 can be closed.

[NejcZdovc]

Will be fixed in #10136