Browser-laptop: about:brave page should have "copy to clipboard" button

[CliqueBait]

I like the recent change to version info. It looks cleaner than presenting a dialog. One downside though is that selecting and copying the info gives me this:

Brave 0.12.10
Muon 1.4.26
libchromiumcontent 53.0.2785.143
V8 5.3.332.47
Node.js 6.5.0
Update Channel dev
os.platform linux
os.release 4.8.0-27-generic
os.arch x64

It might be better to add a "copy to clipboard" button which provides something slightly easier to scan when pasted into issue tickets:

Brave: 0.12.10
Muon: 1.4.26
libchromiumcontent: 53.0.2785.143
V8: 5.3.332.47
Node.js: 6.5.0
Update Channel: dev
os.platform: linux
os.release: 4.8.0-27-generic
os.arch: x64

That's basically the text content format of the old dialog.

[srirambv]

5693 should be able to cover this as well

[bsclifton]

This is a great idea- we're already integrated with a clipboard library, this should be a slam dunk :smile:

[gyandeeps]

I am trying to get my feet wet with brave code. Can I work on this issue and send my first PR?

[bsclifton]

@gyandeeps that would be awesome! I can help you along the way :smile:

@bradleyrichter do you have a recommendation of how a "copy to clipboard" button would look? (and where it may go in relation to the current about:brave screen)?

_edit_:
I'm guessing we could just use FontAwesome (which we're already integrated with). Would be just adding some class names to the button (maybe the clipboard one here?)

[bradleyrichter]

That FA icon is perfect.

On Dec 8, 2016, at 10:34 AM, Brian Clifton [e-mail] wrote:

@gyandeeps that would be awesome!

@bradleyrichter do you have a recommendation of how a "copy to clipboard" button would look? (and where it may go in relation to the current about:brave screen)?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[gyandeeps]

Thanks @bsclifton and @bradleyrichter for giving all this info. The only thing left is where shoudl this icon be placed on the about page (top, bottom , etc)?

[bradleyrichter]

@gyandeeps

How about this?

[gyandeeps]

looks good to me. I will go with this design as of now unless somebody recommends something else.
Thanks @bradleyrichter

[CliqueBait]

Thanks for volunteering time to this @gyandeeps . I'll have to get my feet wet soon too.

[bsclifton]

That would be awesome, @CliqueBait :smile: Let us know if you have any questions

[bbondy]

reset milestone for now.
This issue is blocked because of:
https://github.com/brave/browser-laptop/issues/6183
And some comments in the PR.

[luixxiul]

Test plan: https://github.com/bsclifton/browser-laptop/commit/0d4eba52fcd143d28be79115ea76157f543140d7