Browser-laptop: About pages right click context menu has an extra separator

[srirambv]

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
About pages right click context menu has an extra separator

Expected behavior:
Extra separator should be removed

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows 10 x64

• Brave Version:
  0.12.10 RC1

• Steps to reproduce:

  1. Open any about page
  2. Right click to show the context menu
  3. Has an extra separator after Find

• Screenshot if needed:
  

• Any related issues:

  5600

  cc: @bsclifton

[srirambv]

Context menu in about:bookmark also has an extra separator

[bbondy]

Moving to 0.12.11 because we won't respin an RC for this.

[luixxiul]

the context menu on about:history too

[cndouglas]

I cannot reproduce with 0.12.10 final release on macOS 10.12.x.

[bsclifton]

@Liunkae this is only a problem on Windows / Linux; Mac strips out unneeded separators

[bbondy]

Re-opening because it breaks bookmark folders.
STR:

1. Clear session storage.
2. Create a bookmark folder
3. Load a webpage and click the star button
4. In the folder drop down select the bookmark folder.
5. Try to click or hover over the bookmark folder.

[bbondy]

This also breaks bookmark tests.

[bsclifton]

@bbondy doh, thanks for the catch. I'll dig into this tonite and ensure tests look good locally

[bsclifton]

Root cause found! It has to do with only 1 item being in the folder... which is great that the Bookmarks toolbar test does this :smile: I'll make an explicit test for this, fix the issue, and then resubmit a PR

[srirambv]

This is still an issue if the password manager/pocket extension is not enabled on 0.13.0 Preview 5
Same on new tab also.

related fix #5869

cc: @bsclifton

[luixxiul]

Test plan: https://github.com/brave/browser-laptop/pull/6374#issue-197024290