Browser-laptop: Refine the Brave button (look, positioning, feel) on Windows

Created on 23 Oct 2016  路  6Comments  路  Source: brave/browser-laptop

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
The Brave button (the lion icon) feels awkward on Windows (compared to the macOS version)
screen shot 2016-10-23 at 12 44 31 am

Expected behavior:
Solution should match this mockup by @bradleyrichter:
image

Notice:

  • the caption buttons are vertically centered
  • lion icon has an additional separator to the right

Related:
Similar to https://github.com/brave/browser-laptop/issues/4591

OWindows Qchecked-Win32 Qchecked-Win64 featurtitlebar

Most helpful comment

Here are some WIP screenshots, cc: @bradleyrichter

no menu w/ magic titlebar
screen shot 2016-11-05 at 12 45 53 am

menu w/ magic titlebar
screen shot 2016-11-05 at 12 46 38 am

no menu w/ URL bar
screen shot 2016-11-05 at 12 47 35 am

menu w/ URL bar
screen shot 2016-11-05 at 12 47 14 am

All 6 comments

@bradleyrichter When implementing, I discovered an issue with this design:
windows1

The caption buttons have their vertical centering throw off on resize 鈽癸笍

For a demo, I tried putting the menu UNDER the navigation bar. This looks and feels pretty decent 馃槃
windows2

This is consistent w/ IE behavior too:
windows3

What do you all think? (cc: Windows users- @srirambv @jonathansampson). The styles can be updated to look halfway decent (matching Bookmarks Toolbar)
screen shot 2016-10-23 at 2 19 41 am

@bsclifton The file menu popping under the URL bar looks good. +1 for this to go with Windows build.

If this behavior is implemented then I would suggest to disable Always show menu bar.

Moving this to 0.12.8; I know @bradleyrichter is still finalizing the placement- I like it under the menus too :smile: It would be good to see what the public thinks

Moving to 0.12.9. We did talk over Slack and have worked out an ideal scenario:

  • screenshots in original post is accurate
  • menu will NOT move beneath the nav bar (this is not standard)
  • Brave logo and extensions will go under the caption buttons if menu is being shown

Here are some WIP screenshots, cc: @bradleyrichter

no menu w/ magic titlebar
screen shot 2016-11-05 at 12 45 53 am

menu w/ magic titlebar
screen shot 2016-11-05 at 12 46 38 am

no menu w/ URL bar
screen shot 2016-11-05 at 12 47 35 am

menu w/ URL bar
screen shot 2016-11-05 at 12 47 14 am

Re-opening after testing on Windows 7 (see screenshot)

Working on a fix now...

screen shot 2016-11-09 at 12 12 50 pm

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jonathansampson picture jonathansampson  路  3Comments

luixxiul picture luixxiul  路  3Comments

luixxiul picture luixxiul  路  3Comments

octohedron picture octohedron  路  3Comments

eljuno picture eljuno  路  3Comments