Browser-laptop: Added tear off tabs - Ability to drag tab into new window

[lucidNTR]

Did you search for similar issues before submitting this one?
yes

Describe the issue you encountered:
if i want to have a new window for a tab other browsers allow dragging a tab out of the window to create a new window. i expect the same behaviour in brave.

Expected behavior:
see above

• Platform (Win7, 8, 10? macOS? Linux distro?):
  macos
• Brave Version:
  master

Steps to test: (edited in by bbondy)

• Drag last tab from a window into an existing other window
• Drag a tab out of an existing window, not last tab.
• Use context menu on tab to detach
• Make sure pinned tab can't be dragged out
• Make sure detach item doesn't appear on pinned tab
• Make sure no detach context menu on tab if it's the last tab.
• Test pinned tabs fully that they work as expected.

[getsetbro]

Also dragging a tab from one open window to another open window should move it to the opened window that it was dragged to. Currently it does not move it (tested on Mac El Capitan version 10.11.6).

[cndouglas]

Not to be confused with #405. This issue refers to creating a new window with an existing tab (still in the same Brave process).
Edit: Actually, #405 is a duplicate of this.

[echosa]

Additionally, I would expect there to be a right-click menu option for "Move To New Window" when right-clicking tabs.

[cndouglas]

This is an essential feature every major browser has. I'll set the milestone to 1.0 for now. Please change/remove the milestone if needed.

[srirambv]

+1 from support

[srirambv]

+1 from support

[outragedhuman]

+1 essential feature

[luixxiul]

Another request: https://community.brave.com/t/moving-tabs-from-one-browser-window-to-the-next/529?u=suguru

[yannduran]

👍

[CliqueBait]

+1 from Community: https://community.brave.com/t/second-window-for-dual-monitors/1067

[ryanleesipes]

Just adding another supporting comment for this feature. I'm excited to see this make it in. Are there any branches/anyone currently working on this?

[NejcZdovc]

You can see progress here https://github.com/brave/browser-laptop/pull/6929

[ivanstegic]

This is currently a deal breaker for me: I didn't realize how much I sort and rearrange tabs until I couldn't do it. Looking forward to the feature being added!

[amc2002]

Deal breaker here too. I love Brave, but rearranging tabs and breaking them off to new windows is essential. Had to go back to Firefox. :(

[echosa]

Agreed. I've been keeping a list of issues with Brave that will make me switch back to another browser if not fixed. This is one of the (currently) 10 items on that list.

[ivanstegic]

@echosa what are the other items? Do you have them listed somewhere, I'd love to see them!

[echosa]

Well, I did just have this as some terse notes in a private Fastmail note. Then you had to go and ask for it publicly, so I had to write out some better descriptions, and go aggregate all the links to the appropriate GitHub issues. :-P

So, here you go: https://gist.github.com/echosa/ed4a150d74e96fc6d54b72a8ae853a61

[ivanstegic]

Thank you good sir, starred the list. Some of those are annoyances for me, but not deal breakers... like the YouTube ads one. If this was reddit, I'd gold you.

[echosa]

Indeed. There's a reason the ads issues are so far down the list. I suppose I could break the list into "must haves" and "nice to haves", but meh. It's fine as is for now.

Enough side-tracking this issue, though. :-)

[bsclifton]

Thanks for sharing the list, @echosa 😄

[echosa]

:-) I'm really trying to stay on Brave as default, but these things are making it difficult. I consider switching away, then switching back when Brave meets more of my requirements. :-P I love Brave. I love the idea of it. I enjoy using it (when it does what I need). However, if there's already a browser out there that meets my needs, it's difficult to turn it away. I'm trying, though. That's for sure.

[jonathansampson]

+1 from Twitter: https://twitter.com/Nilpferdo/status/844971940850941952

[bbondy]

Done, finally!
https://github.com/brave/browser-laptop/pull/8084

[luixxiul]

@bbondy would you mind adding QA steps if any? Thanks! :-)

[bbondy]

I edited in steps to test in the first comment @luixxiul