Browser-laptop: Unable to open private tab using keyboard shortcut from a PDF tab

[srirambv]

Test plan

1. Open any pdf: http://unec.edu.az/application/uploads/2014/12/pdf-sample.pdf
2. To open a new private tab: Press Ctrl + Shift + P
3. Result: Launches a new private tab.

Original issue description

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Unable to open private tab using keyboard shortcut from a PDF tab. When Ctrl+Shift+P is pressed it opens print dialogue instead of launching a private tab

Expected behavior:
Should open a new private tab

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows 10 x64
• Brave Version:
  0.12.1 RC1
• Steps to reproduce:
  
  
  
  1. Open any pdf in a tab
  
  
  2. Press Ctrl+Shift+P to open a new private tab
  
  
  3. Launches print dialogue instead of opening a new private tab
  
  
• Screenshot if needed:
• Any related issues:

[z-no]

Also seeing this on mac osX El Capitan, for brave v 0.13.4

[srirambv]

+1 from #11112

[sergio-rojasa]

I would like to work on this issue

[bsclifton]

@sergiorojasa awesome! Go for it 😄 I've assigned the issue to myself so that nobody will grab it. Let us know if you need any help

[sergio-rojasa]

I found the newPrivateTab keyboard shortcut in app/common/commonMenu.js
and I reproduced the issue on my computer, but I not sure if the issue is in brave/pdf.js repository or brave/browser-laptop repository because when the browser loads a pdf the pdf.js extension logic is loads

[sergio-rojasa]

I found out when a user press ctrl+shift+p the pdf chrome extension code execute the print method.

[sergio-rojasa]

@bsclifton on line 273 - 278 is where the code executes the print command Click to view the pdf.js repository pdf_print_service.js

[sergio-rojasa]

@bsclifton I was not sure how to do the pull request for this issue, on this repository or brave/pdf.js repository so I did a pull request on brave/pdf.js repository.

[diracdeltas]

this will be fixed whenever https://github.com/brave/pdf.js/pull/4 is merged into master and @bsclifton does a pdf.js release :).

[NejcZdovc]

@bsclifton should we add to any milestone this one?

[bsclifton]

@NejcZdovc good catch- yes... we are fixing this with 0.22.x release 3. Will set accordingly

[btlechowski]

Verified on Ubuntu 17.10 x64

• 0.22.703 903b8d0d
• libchromiumcontent 66.0.3359.139
• muon: 6.0.8

Verified with macOS 10.12.6 using

• 0.22.703 https://github.com/brave/browser-laptop/commit/903b8d0d3703b5fdc5a719294403e7460d9b806d
• muon 6.0.8
• libchromiumcontent 66.0.3359.139

Verified on Windows x64

• 0.22.703 903b8d0
• libchromiumcontent 66.0.3359.139
• muon: 6.0.8