Browser-laptop: 1password button does nothing after switch toggle and 3 reboots

Created on 14 Sep 2016  路  13Comments  路  Source: brave/browser-laptop

mac

0.12.1

image

CC @bridiver

bug

Most helpful comment

0.12.0 - 1PW works with Ctrl+\ opens up the mini app
0.12.1(Preview Build) - 1PW works with Ctrl+\ opens up the mini app but the widget next to Shields doesn't launch the mini app
0.12.1(RC1) - 1PW works with Ctrl+\ opens up the mini app, Clicking on the widget also opens up the mini app.

All 13 comments

I can repro on Windows; the extension's widget shows, but it's not clickable

I can't repro on mac. @bradleyrichter can you send me your user data dir? @bsclifton what version of 1password? I have no idea if Brave is supported on 1pw6 for windows and there is no option to disable code signature checking

can you guys check if it is also a problem with 0.12.0?

actually I did get 1pw to work on 0.12.0, but that was a release build with code sig. I'll try it with the dev tag

I think @bradleyrichter has an older preview release with a bug that broke the extension buttons. He said 1pw works from the context menu which is consistent with that theory. I need to check windows with a release build to verify that I'm seeing a code sig issue and not an actual bug

@bridiver 1PW 6 is definitely supported (as in the code signature was added) as of version 6.0197 (release notes for Windows here)

I'm on Windows 10 pro x64 and w/ 1PW, I was on version 6.0.207. I just noticed an update is available which I downloaded and tried (6.0.214). The extension button still doesn't work... however, 1Password mini works just fine (if I hit ctrl + )

@bsclifton are you using dev or release build? Is it the most recent preview?

let's check back on this tomorrow when a new build is available

I'm particularly looking for people who can reproduce it on 0.12.1, @bsclifton and @bradleyrichter, can you also reproduce the problem on 0.12.0?

0.12.0 - 1PW works with Ctrl+\ opens up the mini app
0.12.1(Preview Build) - 1PW works with Ctrl+\ opens up the mini app but the widget next to Shields doesn't launch the mini app
0.12.1(RC1) - 1PW works with Ctrl+\ opens up the mini app, Clicking on the widget also opens up the mini app.

Thanks for clarifying, @srirambv so this can be closed then?

also confirmed!

  • 0.12.0 - doesn't show the extension button (because it didn't exist yet), but 1PW works fine
  • 0.12.1 RC1 - extension button works great

@bridiver suggested that it could be an issue of the code signature when running a dev build (which is how I noticed the issue)

I also tested on win and mac and everything looks good. I think the previous release was missing the fix for the extension button so I'm going to go ahead and close

Was this page helpful?
0 / 5 - 0 ratings

Related issues

bbondy picture bbondy  路  3Comments

stevespringett picture stevespringett  路  3Comments

lukemulks picture lukemulks  路  3Comments

jonathansampson picture jonathansampson  路  3Comments

jonathansampson picture jonathansampson  路  3Comments