Browser-laptop: Split components out of preferences.js
This is just a nice to have, but there are like 20 components inside of the preferences.js file. It would be nice to split them out into separate files for testing / readability / making them easier to find.
jkup
👍2
All 2 comments
Also I鈥檓 wondering if it would improve readability of preferences.less by separating it to files in a folder like this:
less/about/preferences/preferences.less
less/about/preferences/general.less
less/about/preferences/search.less
The common rules should be set in preferences.less and the other files should be imported to it.
luixxiul
on 23 Nov 2016
👍2
@luixxiul this is definitely a good call! My only worry is spending time on LESS when we are moving to Aphrodite. Maybe it would be best to split the .js files up and then one by one move the applicable preferences.less stylings into Aphrodite objects?
jkup
on 23 Nov 2016
👍1
Was this page helpful?
0 / 5 - 0 ratings
Related issues
luixxiul
路
3Comments
shortstuffsushi
路
3Comments
jkup
路
3Comments
bbondy
路
3Comments
jonathansampson
路
3Comments
Most helpful comment
Also I鈥檓 wondering if it would improve readability of preferences.less by separating it to files in a folder like this:
The common rules should be set in preferences.less and the other files should be imported to it.