Browser-laptop: Bookmark title is not updated unbookmarking/rebookmarking

[luixxiul]

• Platform (Win7, 8, 10? macOS? Linux distro?): Windows 7 64 bit
• Brave Version: 0.11.6 Beta1
• Steps to reproduce:
  
  
  
  1. Move away your brave folder temporarily
  
  
  2. Navigate to https://github.com/brave/browser-laptop/issues/3283
  
  
  3. Bookmark the page
  
  
• Screenshot if needed:
  
• Any related issues: #3283

[bbondy]

iii. Bookmark the page

For steps to reproduce pls be super specific, thanks. In which way did you bookmark, maybe the star button?

[bbondy]

This is working for me

[bbondy]

What is the "actual results" and "expected results"?

[luixxiul]

I can reproduce the issue by bookmarking this page with pushing CTRL+D and clicking Save.

The actual result is that the bookmark is saved with the title Issues · brave/browser-laptop, while the expected one is the title Bookmark name is wrongly saved on GitHub issue page · Issue #3284 · brave/browser-laptop.

[luixxiul]

I assume that database files were corrupted at some point, but this seems to me not an accident because I experienced the same issue on Windows 10 too. On clean install I cannot reproduce this.

[bsclifton]

I believe I understand the issue and why we are not able to reproduce it

Bookmark names are saved after they are changed, even after you remove the bookmark. The only way to truly clear the item out is to clear the history.

Here are some steps you can try to reproduce
1) Bookmark any page
2) Edit the bookmark, give it a custom title of "ABC"
3) Remove the bookmark
4) Re-bookmark the page
5) Notice the name is now "ABC"

[bsclifton]

Working on a fix for this now...

[BrendanEich]

Dup of #3080?

[bsclifton]

We want the behavior of keeping the custom title-

I believe after pulling hairs out I have characterized the problem (thanks @BrendanEich!)

• bookmark a page (let's say it has title "old title")
• remove bookmark. You no longer have this item bookmarked.
• [time goes by; page owner changes the title]
• bookmark the page again (same URL as before; this page has title "new title")
• title is being set to the OLD title ("old title")

The title of a web page is not something that is changeable by a user; we should always use the latest title available. Custom titles however are fair game.

In the add/edit modal, any text changes to the title will automatically re-calculate the custom title of the bookmark (and this does work).

[bsclifton]

Fixed with https://github.com/brave/browser-laptop/pull/3339, ready for review :smile:

[luixxiul]

It seems that the issue started to appear on the latest beta again..

[bbondy]

won't block 0.11.6 on it.

[bsclifton]

@luixxiul - please see the above notes. If you re-bookmark, the actual title of the bookmark IS properly updated. However, it will copy the custom title. Your original issue above shows the old (now incorrect) title being assigned to a new bookmark of the page.

I'd like to ask @bradleyrichter -what is your preferred behavior? My understanding is that we want to preserve the custom titles that are given to bookmarks

[bradleyrichter]

@bsclifton I don't think any users would be upset if we don't auto-restore their long lost custom title, but many will be annoyed that the old title seems stuck to the page.

My suggestion is to toss the title when a BM is removed, and monitor user feedback in general for bookmarking.