Browser-laptop: Add delete confirmation to downloads bar

Created on 20 Jul 2016  路  7Comments  路  Source: brave/browser-laptop

Test Plan

  • Download a file
  • try to delete it from the downloadsBar
  • notice new confirmation bar

    • click ok to remove the file

    • move the mouse outside the downloadItem panel to hide the confirmation bar.

Original issue description

"Delete Download" on download bar should have a warning prompt.

  • Any related issues: #1076 #1202
Qchecked-Linux Qchecked-Win32 Qchecked-Win64 Qchecked-macOS Qtest-plan-specified bugood-first-bug featurdownload parity release-noteinclude

Most helpful comment

How about something like this? (l10n friendly)

image

All 7 comments

An additional reason to add a confirmation here is because when downloading and you open the status-bar download box the "open in folder" is the last icon shown at the right. When the download completes the first icon on the left, "pause", is removed and a "delete" icon is added on the far right. This effectively replaces the "open in folder" icon with the "delete" icon in the same spot and nearly instantly when the remaining icons shift left to fill the hole left by the removal of the "pause" icon.

Maybe change the icon order so that the pause is replaced by the delete, in the far left location, until the confirmation option is available?

On the other hand it is nice to see that the delete icon can quickly remove a 4 GB ISO download that has just finished. :-(

This effectively replaces the "open in folder" icon with the "delete" icon in the same spot

wdyt @bradleyrichter ? I noticed this too.

+1, accidentally deleting downloads should be difficult imho

How about something like this? (l10n friendly)

image

That would solve my problem completely and it looks pretty sharp too.

Solution: #5969

from #5969, here are the acceptance criteria per @bradleyrichter:

Deleting files is destructive and can not be undone. Thus, it needs a minimal confirmation.

Adding this to the delete bar UI keeps the confirmation focused at the point of interaction rather than opening a dialog.

To cancel, click outside of the popup box.

image

Was this page helpful?
0 / 5 - 0 ratings

Related issues

bbondy picture bbondy  路  3Comments

eljuno picture eljuno  路  3Comments

bsclifton picture bsclifton  路  3Comments

luixxiul picture luixxiul  路  3Comments

jonathansampson picture jonathansampson  路  3Comments