Browser-laptop: Window menu on Windows should have preferences

[bbondy]

Preferences doesn't appear anywhere in the top level menu otherwise.
Use process.platform for the code in app/menu.js

[bsclifton]

This is already showing in the Edit menu... should it also be showing the Window menu?

[cezaraugusto]

Good catch @bsclifton. I was almost sending a PR for this.

Should we keep it under Edit or Window menu is better?

[bbondy]

Oh didn't notice that. Not sure which is better. @bradleyrichter ?

[bradleyrichter]

Actually, on Windows and Linux, "Preferences..." should really be "Settings..." to active Win user's muscle memory.

Old-style windows standard for placement was in Edit.

Today it has moved to the hamburger in most if not all Windows apps. (like onenote, money, etc.)

@bsclifton So, let's rename to "Settings...". Leave it in the burger. Add it to "Edit".

[cezaraugusto]

@bradleyrichter so it should be renamed on both Edit and burger menu?

Also, how can we deal about this name changing on i10n? Something we need to worry about?

[cezaraugusto]

Nevermind, figured out a good way to do it.

[bbondy]

Only add in english localization file btw, and yes in both places it should be called Settings on Windows.
@bradleyrichter btw Chrome calls it Settings everywhere. Firefox uses Preferences... on macOS and Options on windows. Maybe we should just use Settings everywhere to be consistent with what has the most market share?

[bbondy]

it might make it easier for documentation we write in the future to be consistent.

[bradleyrichter]

Chrome on mac actually mixes both but that doesn't surprise me.

I know it ads more pain but it doesn't seem right to me to break history on Mac and put "Settings..." in the App menu so let's please keep them OS specific so users can more quickly identify them when looking.

[bbondy]

wow crazy!