Browser-laptop: Added "Save my downloads here" setting

[bradleyrichter]

Test plan

https://github.com/brave/browser-laptop/pull/7023#issue-205124002

---

Functionality:
Providing a user-definable default downloads destination allows for a more efficient user work flow when downloading files. The default path is their downloads folder. This path can be changed by clicking on the pencil (edit) button. This opens a download location chooser dialog which is OS specific.

A toggle switch (off by default) allows the user to change the setting to ask them for the desired location upon each file download.

item label:
"Save my downloads here"

toggle switch label:
"Always ask me where to save files"

Download location sheet-dialog in Mac:

Spec image: (this issue in blue)

[NejcZdovc]

It's really annoying not having this and selecting folder for every single download. Will add this :smiley:

[bradleyrichter]

Yes! TY!

On Feb 2, 2017, at 10:27 PM, Nejc Zdovc [e-mail] wrote:

It's really annoying not having this and select folder for every download. Will add this 😃

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[cndouglas]

A toggle switch (off by default) allows the user to change the setting to ask them for the desired location upon each file download.

This is what I get on a fresh install:

Should the switch be on or off by default?

[NejcZdovc]

I set it to on by default yes. If we go with the off by default, then I think we would need to set default path when browser is first lunched (or when you go to preferences, we use same function for path determination that we use it on the save event), otherwise it would be strange to have empty input and option to off

cc @bradleyrichter