Browser-laptop: General Settings: "A new tab shows" setting

[bradleyrichter]

Functionality:
"my new tab page"

• shows the current version of a new tab page (blank white at time of writing)

"my home page"

• shows the currently defined home page

"my default search engine"

• shows the home page of the currently set default search engine

Item label:
"A new tab shows"

Menu choices:
"my new tab page"
"my home page"
"my default search engine"

menu snapshot:

Settings panel: (item for this issue shown in blue)

[kingscott]

Any chance this has been taken on? I just started the early stages of writing something of this sort. Any chance I could work on it or collaborate? @bradleyrichter

[bradleyrichter]

@kingscott We'd love to have your help!

This has not been started yet, besides what is currently implemented in today's release in the general prefs panel which is limited to startup, not a new tab view.

For code review, we can ask @bridiver or @bbondy .

[kingscott]

Great, thanks @bradleyrichter! I was jumping into it today at the end of my work day. Is that settings panel mentioned in the above image what has been agreed upon for production?

[bradleyrichter]

Hey @kingscott - I just updated it for you. But, please don't bother with the visual elements because we are currently working on a branch which is a complete prefs makeover.

We will have to merge your new code with the new UI work. Shouldn't be a problem...

If you want to take a look at the progress on that branch, here it is:

https://github.com/brave/browser-laptop/tree/cherry-picked-ui-updates

[bradleyrichter]

I’m all ears…

On Jun 27, 2016, at 10:45 AM, Scott King [email protected] wrote:

Hey @bradleyrichter https://github.com/bradleyrichter, just a quick opinion question for functionality. I have had a few ideas for this new tab stuff

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/brave/browser-laptop/issues/2106#issuecomment-228820036, or mute the thread https://github.com/notifications/unsubscribe/AM4jqqe4dYkyn7p1B_btu1xRt1rq8jq2ks5qQAwxgaJpZM4Ivb8W.

[kingscott]

Sorry about that, I had thought and didn't mean to write the comment (was trying to overcomplicate the task).

Also, did you want (or need) the new tab page created that has the tiles of previously visited pages?

[bradleyrichter]

@kingscott We would love the help on anything you are interested in working on. Here is a screen shot of the currently proposed "Top Sites/Info Page" but I haven't finished the details in the spec.

When you mouse-hover over the topsite thumbs, you would get the full page preview rendered behind the shadow masking:

There will be a neat UI to change the layout of the top site icons by clicking on a toggle button to change from 1, 2 or 3 rows, and a list view.

Let me know if this looks interesting to you...

Thanks!
Brad

[kingscott]

Wow, that looks really nice! Honestly - the top image looks awesome. I tend to prefer the more neutral images for new tab stuff.

Is that something you (Brave) would want me to build? In terms of the background, I do have a project I worked on that pulls in nice backgrounds. I have a Chrome extension for it as well. If that was of interest, I can extend and/or integrate with Brave. PS. It's in React as well.

EDIT: Just re-read the comment for the second picture - so disregard my second comment in the top paragraph. Sounds truly great 👍

[bradleyrichter]

Hey Scott - can I invite you to join our #community slack channel?

Also - I installed the chrome extension. Looks good. I think this is right up your alley. : )

[kingscott]

Sure, that would be great Brad!

[bradleyrichter]

@kingscott Just invited you as a contributor...

[kingscott]

Yes @bradleyrichter, I got it - thanks!

[bsclifton]

Original work done in PR https://github.com/brave/browser-laptop/pull/3488

[0xMF]

Please bring back the empty New Tab option (applies to v. 0.12.9; win32; x64).

[luixxiul]

5652 addressed the issue but I would have to say I preferred the option than leaving the home page URL empty.