Browser-laptop: Audio indicator shows for any playing video / image

[bbondy]

It should only show for playing audio, not for embedded GIF etc.

[luixxiul]

Was this fixed?

[bbondy]

no we still show it anytime there is playing video I think even when the audio is not there and muted.

[cezaraugusto]

@bbondy what is the expected behavior? Should it include a muted icon if its muted and a video icon when its video?

Also, would it be a good first bug?

[bbondy]

Probably no icon for video only with no sound. But I think this might not be the best of first bugs unless you want to look into electron for a fix.

[paanvaannd]

Something else I noticed about this behavior: my pinned NYtimes tab shows a blank spot (refer to screenshot below) where the audio playback status showed previously.

OS: macOS 10.12 Beta 4

About the issue:

• there was no audio or video playing in the main page but for an animation (I assume it was a GIF, as I saw no playback controls for it) on the main page
• the audio indicator showed that there was audio for the animation though there was not
• upon refreshing the page a couple hours later, the animation is no longer there on the front page though there is another GIF further down the page (definitely a GIF, no playback controls there)
• the pinned tab now has a blank area where the indicator was previously though there is no indicator there now
• unpinning and re-pinning the tab does not fix the gap issue
• creating a new tab for the same URL and pinning it results in a normally pinned tab without the gap as mentioned above

e: for clarification, though I reopened the same URL with the GIF mentioned in the 3rd bullet point (which was _not_ the GIF that caused the sound indicator to erroneously display in the first place, since that was removed from the front page) when testing pinning a newly created tab for the same URL, there was no sound indicator. It seems like something specific about that animation that was playing before in the first bullet point (the animation at the very bottom of this article, to be specific) that caused the indicator to erroneously display, as this second GIF does _not_ cause the indicator to display though it was present in both cases.

NOTE: upon visiting the link to the animation I had attributed to the cause of the erroneous indicator playing in the 1st bullet point in a newly created and pinned tab, there was no indicator displayed. The differences in this case were that this animation was not on the main page of NYTimes but in an article itself. Within this article, the animation takes on a click to play behavior whereas when it was on the front page of the site it had an auto play behavior. There was no other video or animation playing when the indicator was showing previously when this animation was auto-playing on the front page.

TL;DR: Inconclusive results in testing for causes of erroneous indicator activation in the NYTimes website (refer to links above) so I don't know why it was activated in the first place. Further testing needs to be done on how the gap persistence behavior on a pinned tab can be reproduced and under what conditions the gap persists.

[joneschrisg]

I'm seeing the narrower issue of a gap remaining in the pinned tab area in Brave 0.12.1, OS X 10.11.6, when chatting in gmail pinned tab:

The audio snippets from chat notifications are pretty quick, so this smells like some kind of race condition.

Since this is happening after the audio-playing indicator is being displayed correctly, should we file a separate issue for this rendering glitch? (In other words, this issue could be resolved, but most likely the intermittent rendering glitch would remain.)

[bsclifton]

+1 from https://github.com/brave/browser-laptop/issues/6488

Steps to reproduce:

• Navigate to https://twitter.com/ThePracticalDev/status/814551019522785280
• Click the blue play button
• Observe tab contents as GIF plays

[aleclarson]

Getting an audio indicator for a <video> element with muted (and no audio track to begin with).

[bsclifton]

Closing as wontfix since this is fixed with Brave Core