There are about 130 pages for the Window interface which are still showing the old tables and have no data migrated. See https://developer.mozilla.org/en-US/docs/Web/API/Window$children for all sub pages.
Migrate this data to api/Window.json.
It is probably easier to open smaller PRs and chunk the work a bit. Maybe do like 20-30 at a time (e.g. members starting with letters A to F or so).
@maboa Do you want to start with this work?
I can pitch in. I will get started with letters A to F.
@Elchi3 As I started going through the list, I quickly realized some of the sub features don't have compatibility table on MDN. How do we handle such cases?
We can ignore them for now.
If you ignore them, they you should maybe add them to the MDN Browser Compat Data Migration Google Sheet (that鈥檚 what I鈥檝e been doing when I convert a sub-feature of a large interface).
@Elchi3 I have covered A-L letters so far, but I need to get couple of things cleared before I send out a PR.
There are few features with more than one row in the compatibility table, such as
localStorage. How that gets fit into JSON? Couldn't find any details in schema file or docs.
As sub-features of sub-features.
There are few features with support info for "Firefox Mobile", "Opera Mobile" and "Android", however I don't see direct browser identifiers for those browsers in schema doc. Should they be ignored? Or they can be mapped to "firefox_android", "opera_android" and "webview_android" respectively?
Yes:
| Old | New |
|---|---|
| Firefox Mobile | firefox_android |
| Opera Mobile | opera_android |
| Android | webview_android |
I had actually started working on that long list of Window properties over the past few weeks (hence my name in the Window column before the sub-rows got created in the sheet). I guess the confusion came from the fact that there was an already committed Window.json from someone's earlier work and you thought I was done with it?
Luckily (for my own sanity :)) I wasn't too far in, I'll discard my work so far and remove my name from the Window row.
It looks like you've got it covered but let me know if you need more help on this one.
Just raised a #2109
Copying estimate and assignment from sprint planning
What's missing here seems to be addressing the reviewing comments and merging https://github.com/mdn/browser-compat-data/pull/2021
I just added the events and went through all the children of Window. Mostly they look good, but:
it looks like we missed window.cancelAnimationFrame()
window.URL and window.StaticRange both still have the old-style tables and no BCD entries. Is this because they are constructors?
@wbamberg they've been listed in the spreadsheet for a while, I think they should still be added
PR for window.cancelAnimationFrame -> https://github.com/mdn/browser-compat-data/pull/2564
Talking to @a2sheppy in IRC confirmed that we should remove the content of the window.URL and window.StaticRange pages, and make them redirect to the docs for those APIs. So I've done that too.
(in reply to @wbamberg from https://github.com/mdn/browser-compat-data/issues/2011#issuecomment-410866426)
Talking to @a2sheppy in IRC confirmed that we should remove the content of the window.URL and window.StaticRange pages, and make them redirect to the docs for those APIs. So I've done that too.
Have you made sure to transfer any information that was only in window.URL to URL and window.StaticRange to StaticRange鹿?
鹿 Assuming that there was such a case虏.
虏 I鈥檓 asking, as I encountered such a case during #2184 and adding the redirect to MDN. Same with :鈥憁oz鈥憄laceholder.
Have you made sure to transfer any information that was only in window.URL to URL and window.StaticRange to StaticRange鹿?
I don't think there was any.
The last one here was https://developer.mozilla.org/en-US/docs/Web/API/Window/cancelAnimationFrame#Browser_compatibility which I've just updated to use the new table.
Thanks everyone who helped with this giant one! :tada: :tada: :tada:
Most helpful comment
The last one here was https://developer.mozilla.org/en-US/docs/Web/API/Window/cancelAnimationFrame#Browser_compatibility which I've just updated to use the new table.
Thanks everyone who helped with this giant one! :tada: :tada: :tada: