Brigade: Releases for brig cli for Windows lacking .exe extension

[LittleColin]

Downloading brig-windows-amd64 from the releases page at: https://github.com/Azure/brigade/releases

This gives a file without any extension but is actually a .exe file. Renaming to brig.exe and putting it in path then makes it work but I've not seen this mentioned in the readme.

[LittleColin]

Ah now I realise the problem, I've now spotted the following in release 0.15:
https://github.com/Azure/brigade/pull/478

Ironically release 0.15.0 which contains this fix doesn't have the associated windows binary asset attached.

[LittleColin]

It looks like the push is assuming the source file also has the .exe extension but presumably the intention was only the destination should have .exe added.

var name = binName + "-"+f
if (f == "windows-amd64") {
      name += ".exe"
    }
cx.tasks.push(`github-release upload -f ./bin/${name} -n ${name} -t ${tag}`)  

Would this have done it?

    var name = binName + "-"+f
    var destName = name
    if (f == "windows-amd64") {
      destName += ".exe"
    }
    cx.tasks.push(`github-release upload -f ./bin/${name} -n ${destName} -t ${tag}`)  

[technosophos]

@LittleColin Oh, yes -- your suggestion would fix it.

[LittleColin]

Seems we've lost the .exe extension for brig in v0.18.0 (previous two versions had the .exe extension)

[blimmer]

Have we ever considered using go-releaser? https://github.com/goreleaser/goreleaser

[bacongobbler]

that's neat! We're using github-release in the CI pipeline which is a subset of goreleaser's features.

[vdice]

@LittleColin apologies for the hiccup (see https://github.com/Azure/brigade/issues/659#issuecomment-429423155). Windows binary now up with proper .exe extension here. Thank you!