Brew: Improve Homebrew/brew code coverage

Created on 27 Aug 2018  路  4Comments  路  Source: Homebrew/brew

It would be good to increase our code coverage. This can be done by adding integration tests (only) for missing cmd and dev-cmd commands (e.g. https://codecov.io/gh/Homebrew/brew/src/master/Library/Homebrew/cmd/diy.rb), figuring out why some coverage is currently missing (e.g. https://codecov.io/gh/Homebrew/brew/src/master/Library/Homebrew/dev-cmd/ruby.rb despite https://github.com/Homebrew/brew/blob/master/Library/Homebrew/test/dev-cmd/ruby_spec.rb) and adding unit tests for files with low coverage (e.g. https://codecov.io/gh/Homebrew/brew/src/master/Library/Homebrew/hardware.rb).

outdated stale

Most helpful comment

@alexbostock, many small PRs are easier to review than a huge one.

All 4 comments

If I make more contributions like #4915, is it better to add lots of tests in the same pull request or make lots of separate pull requests?

@alexbostock, many small PRs are easier to review than a huge one.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

I think this is now good enough (>70%) that we don't need an open issue.

Was this page helpful?
0 / 5 - 0 ratings