Brew: Automatic reinstall on broken linkage

Created on 12 Apr 2018 · 5Comments · Source: Homebrew/brew

We should automatically reinstall formulae when we detect broken linkage after e.g. brew upgrade.

This requires brew linkage to be faster.

outdated

Source

MikeMcQuaid

👍1

Most helpful comment

@AndrewMcBurney Annoyingly the slow bit blocking your PR is this:

have the portable version of Ruby with DBM built?

It's been on my list for a while and I still need to get around to it. I think it's unlikely I'm going to be able to get it done and merged within a week but I'll try my best. If not, I'll finish off any parts of your PR that need done.

MikeMcQuaid on 19 Apr 2018

👍3

All 5 comments

I assume that the reinstall will be a build from source?

scpeters on 13 Apr 2018

@scpeters I think that's a last resort. First it should try just brew upgrade on whatever broke, then try to fill in opportunistic linkage with homebrew/core bottles, and only if both of those fail, fall back on a source build.

ilovezfs on 13 Apr 2018

👍1

Hi @MikeMcQuaid,

I saw you linked the brew linkage issue which I've been working on. Is this automatic-reinstall issue blocked until the cache optimization PR is merged in?

My current internship is wrapping up, and I'll be returning to school within the next week. I won't have time to contribute to open-source projects once the school term starts to pick up.

Would it be possible to get my changes reviewed this weekend, and have the portable version of Ruby with DBM built?

I'm writing a blog post about my experiences finding the bottleneck and contrasting the different implementations (SQLite3, pstore, and DBM), which I'm hoping to publish next week. It would be great if the PR could be merged before then.

Thank you for the time you've devoted reviewing the multiple iterations of the PR, and for the subsequent feedback - it has been very helpful!