Brave-ios: Can’t open link a new tab

[dcorvasce]

Description:

Open a new link in a new tab in Brave, on iOS 12.2b, it is not possible by long pressing on the link—since the Open in a new tab is not available.

I have to open a new tab and copy&paste the link manually.

Steps to Reproduce

1. Go on a page with a link
2. Long press on the click
3. Look for the ‘Open in a new tab’ option

Actual result:

Available options:

• Open
• Add to 'Reading list'
• Copy
• Share

Expected result:

Long pressing on the link provides the option to open the link in a new tab.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Everytime I use Brave, since a couple of days ago.

Brave Version:

V1.7.3 (19.01.25.15)

Device details:

iPhone 7 (iOS 12.2 Beta)

Website problems only:

• did you check with Brave Shields down?
• did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

Safari works correctly. So does Chrome.

[iccub]

Thanks for the report.
I saw this bug too, but it does not happen too often for me and it is per-tab based. So closing the tab and opening a new one fixes the bug.

[dcorvasce]

Nice to hear that. I just tried it and doesn’t work for me.

[iccub]

Hey, I just wanted to let you know that this issue is most likely fixed.
It is an Apple's Webkit bug, but we've done some workaround and all should be good.

It won't probably land in the next release however, but in next + 1, so please have some patience and sorry for the problems

Posting here two links for future reference(the Webkit bug related)

https://bugs.webkit.org/show_bug.cgi?id=193366
https://bugzilla.mozilla.org/show_bug.cgi?id=1520629

[dcorvasce]

Okay, thank you for letting me know!

[cndouglas]

+1 from @joha1 in #994.

[eljuno]

+1 from Community https://community.brave.com/t/unable-to-open-in-new-tab/50369?u=eljuno

[willstocks]

Thanks @eljuno! ☺️ Extending the original details in the community link, I can confirm I'm seeing this on any tab I open at the mo 😔

[VimS]

I got the same Issue on IOS 12.2 with Brave 1.8

[iccub]

Sorry for that, we will most likely release a hotfix for this, shortly after 1.9 lands

[srirambv]

• Verification passed on iPhone 7+ / iPhone 6 and iPad Pro running 1.9(19.3.26.19) on iOS 12.2
• Verification passed on iPhone SE running 1.9 (19.3.29.16) on iOS 12.1
• Verified passed on iPad 5th Gen with 12.1. Updated iPad to 12.2 and verified passed on 12.2 as well
• Verification PASSED on iPad Mini running iOS 12.1 & iPhone 6s+ running iOS 12.2
  
  
  
  • long press on links and ensured that Open in New Tab, Open in New Private Tab, Copy Link and Share Linked worked
  
  
  • long press on images and ensured that Open Image In New Tab, Open in New Private Tab, Save Image and Copy Image worked
  
  
  • long press on text and ensured that Copy, Look up, Share.. and Fine on Page worked
  
  
  • long press on the URL and ensured that Paste & Go, Paste and Copy Address worked
  
  
• Verification passed on iPhone SE running 1.9 (19.3.29.16) on iOS 12.2

[nqnx]

Verification passed on iPhone 7+ / iPhone 6 and iPad Pro running 1.9(19.3.26.19) on iOS 12.2

Is that a typo and meant to be 19.3.29.19? Because on iPhone 8, iOS 12.2 and Brave 1.9 (19.3.29.14) it does not work yet.

[iccub]

@nqnx just before 1.9 release we found few crashes related to open in new tab and we had to quickly revert it back and release without this fix.
We plan to release a hotfix for new tab only early this week

[joha1]

we found few crashes related to open in new tab and we had to quickly revert it back and release without this fix.

So that's why I now can't open anythin in a new tab? I can get the popup menu on long press, even when scripts are off, but I now only have the option to open the link (in the same tab... kinda useless), even when I have the scripting shield switched off (=scripts on).

[iccub]

@joha1 yes, we managed to fix it but we found the app was crashing for unknown reasons and we decided to postpone shipping the fix.
As I said before, we will try to push a hotfix release this week

[srirambv]

• Reverified on iPhone 7/6 and iPad Pro running 1.9.1 (19.04.02.12). Context menu option available for long press on a link.

Reverified on iPad 5th Gen running 1.9.1 (19.04.02.12). Context menu option available for long press on a link.

Reverified on iPhone 8 running 1.9.1 (19.04.02.12). Context menu option available for long press on a link.

[iccub]

Brave 1.9.1 is out, please update the app to get this fixed for you

[nqnx]

Thank you very much!

[VimS]

Brave 1.9.1 is out, please update the app to get this fixed for you

Fixed the Issue for me.

[joha1]

Still doesn't work for me.
But the behaviour changed. Now a long press just doesn't do anything, whereas before, it simply opened the link after letting go of it.
With javascrip on, background tabs work as expected.
What else could be wrong on my side?

[iccub]

What's your device model, device version and Brave version @joha1?

[joha1]

@iccub I'm on an iphone SE on iOS 12.2 (16E227). Brave, according to the "about" in settings is on 1.9.1 (19.04.02.12)

So as far as I can see, everything seems current.

[btlechowski]

Re-verified on iphone SE on iOS 12.2, Brave 1.9.1 (19.04.02.12)

[iccub]

@joha1 @btlechowski
The issue is that Open in new tab does not work with javascript disabled(via settings page).
After disabling JS i can reproduce it on my iPhone 7 12.1

That's an interesting edge case, I made separate ticket for it here https://github.com/brave/brave-ios/issues/1055