Brave-browser: [Desktop] Repurpose the global autoplay content setting so that it allows overriding the Chrome policy

Created on 19 Jul 2020  路  10Comments  路  Source: brave/brave-browser

Background: Previously Brave had its own autoplay system, based on a list, b/c Chrome's autoplay policy was crummy. Now Chrome's policy is a lot better than it was, so Brave has removed its custom system and just falls back on Chrome's (https://github.com/brave/brave-browser/issues/9597, https://github.com/brave/brave-core/pull/5970, etc).

However, we still have the global "autoplay" content setting as a vestigial hold over from the previous system. We should use it to allow users to still disable autoplay, if they don't like Chrome's new-and-improved system.

ODesktop QA Pass-Linux QA Pass-Win64 QA Pass-macOS QTest-Plan-Specified QYes feature-request featurautoplay featurglobal-settings featurshields release-noteinclude

Most helpful comment

Always block is very valuable. Please make it work instead of removing it.

All 10 comments

If we don't do this, we should remove the autoplay content setting, to avoid confusion

Screen Shot 2020-07-18 at 8 13 25 PM
FWIW, this is the autoplay content setting referred to above

Always block is very valuable. Please make it work instead of removing it.

Thanks @timkgh. Its useful for us to get a sense of this, so we know what to prioritize. No promises on a final decision, since theres a lot of high priority things on our plate, but its useful to know that its a feature folks would use

Just chiming in on this. This is a critical feature for me. Since this became an issue in Brave I have switched to Chrome Edge. I prefer Brave (especially mobile) but the lack of zero autoplay I only use it for a handful of cases.

+1 from several users in https://github.com/brave/brave-browser/issues/9597

Per @darkdh in https://github.com/brave/brave-browser/issues/9597#issuecomment-660584268

Just verified

per site autoplay setting works
Screen Shot 2020-07-18 at 21 14 24

global autoplay setting doesn't work
issue tracked here
(https://github.com/brave/brave-browser/issues/10807)
Screen Shot 2020-07-18 at 21 16 35

There are three related issues here:

  1. The text incorrect on the global toggle: https://github.com/brave/brave-browser/issues/10810
  2. The global setting doesn't seem to apply in most cases, for most users: https://github.com/brave/brave-browser/issues/10807
  3. For some users / profiles, the site specific setting doesn't work (my profile, for example): https://github.com/brave/brave-browser/issues/10811

Agree with others that global autoplay off should be available and easy to access. It is for us a very high value problem and we find ourselves more and more migrating away from Brave. Simply... Global Autoplay Off Yes/No

Verification passed on

Brave | 1.13.71 Chromium: 84.0.4147.125聽(Official Build)聽dev聽(64-bit)
-- | --
Revision | d0784639447f2e10d32ebaf9861092b20cfde286-refs/branch-heads/4147@{#1059}
OS | Ubuntu 18.04 LTS

Verified test plan from https://github.com/brave/brave-core/pull/6130

Autoplay default setting options
Allowed
image
Blocked
image
Verified Polish translation

Autoplay set default block
Video is blocked
image

Autoplay default allow
Video is player
image

Autoplay blocked through the block list
Video is blocked
image


Verified passed with

Brave | 1.13.79 Chromium: 85.0.4183.69聽(Official Build)聽dev聽(64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | macOS Version 10.14.6 (Build 18G3020)

Verified test plan from https://github.com/brave/brave-core/pull/6130

Autoplay default setting options
Allowed
Allowed

Blocked
Blocked

Autoplay set default = Blocked
Video is blocked
default blocked

Autoplay set default = Allowed
Video plays automatically
default allow

Autoplay blocked on a per site basis
Video is blocked
per site block


Verification passed on

Brave | 1.13.79 Chromium: 85.0.4183.69聽(Official Build)聽dev聽(64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | Windows聽10 OS Version 1903 (Build 18362.1016)

Autoplay default setting options

  • Verified Autoplay option is "Allowed" when toggle is ON in brave://settings/content/autoplay
    image
  • Verified Autoplay option is "Blocked" when toggle is OFF in brave://settings/content/autoplay
    image

Autoplay set default block

Autoplay default allow

Hi @btlechowski

This Autoplay blocker does not work on this site:

https://inet.detik.com/security/d-5149755/sering-dibobol-ini-pembelaan-whatsapp?tag_from=wp_beritautama

I have turned the Global Autoplay Content Setting to "Blocked", but the video keeps autoplaying on the above site, can you help to check?

Thank you.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

qingxiang-jia picture qingxiang-jia  路  3Comments

bsclifton picture bsclifton  路  3Comments

Sondro picture Sondro  路  3Comments

AlexeyBarabash picture AlexeyBarabash  路  3Comments

traffisco picture traffisco  路  3Comments