Brave-browser: [Android] Insecure icon displayed for https upgrades

Created on 17 Jun 2020  路  3Comments  路  Source: brave/brave-browser

Description

Insecure icon shown on https pages

Steps to reproduce

  1. Clean profile 1.10.92
  2. Visit http://https-everywhere.badssl.com/
  3. The lock icon is not shown in the URL bar

Note: Regular sites and YT works as expected. The secure icon is shown in the URL bar.

Actual result

1.10.92
image (2)

1.9.80
image

Expected result

Lock icon should be shown

Issue reproduces how often

Always

Issue happens on

  • Current Play Store version? No
  • Beta build? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet): Samsung Galaxy J3
  • Android version: 5.1.1

Brave version

1.10.92

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information


cc: @brave/legacy_qa @SergeyZhukovsky @deeppandya @anthonypkeane
Reproduced the issue in the tablet by @btlechowski

OAndroid ODesktop QTest-Plan-Specified QYes regression

Most helpful comment

Mixed content issue looks different. AutoupgradeMixedContent upgrades all mixed content without consulting the https-everywhere list.

https-everywhere upgrades consults the https-everywhere DB for connection upgrades. This is an issue on iOS as well: https://github.com/brave/brave-ios/issues/2554

I'm checking if this is limited to https-everywhere.

All 3 comments

I believe this is the same issue we see on desktop:
https://github.com/brave/brave-browser/issues/10190

Mixed content issue looks different. AutoupgradeMixedContent upgrades all mixed content without consulting the https-everywhere list.

https-everywhere upgrades consults the https-everywhere DB for connection upgrades. This is an issue on iOS as well: https://github.com/brave/brave-ios/issues/2554

I'm checking if this is limited to https-everywhere.

Removing from Android milestone based on discussion here https://bravesoftware.slack.com/archives/C0816QH3R/p1592419635325600

Was this page helpful?
0 / 5 - 0 ratings