Brave-browser: Ability to toggle shields (up/down) via keyboard shortcut

Created on 20 Mar 2020 · 11Comments · Source: brave/brave-browser

Description

(Requested via email)
Users should be able to use a keyboard shortcut to toggle the status of shields

design feature-request featurkeyboard-shortcuts featurshields good first issue prioritP4

Source

bsclifton

👍1

All 11 comments

cc: @karenkliu help on suggestions for keyboard shortcut for shields toggle.

rebron on 20 Mar 2020

how about:

on Mac - CMD+SHIFT+S
on Windows - CONTROL+SHIFT+S
on Linux - need help here; I have no experience with Linux 😅

karenkliu on 20 Mar 2020

For Linux I guess CONTROL+SHIFT+S should be fine.

iamzubin on 27 Mar 2020

Hey, I would like to give this a go!

@bsclifton - I would like your thoughts on if I'm looking at the right files here (https://github.com/edwardqiu/brave-core/commit/b30878f006f2d2c8d7673ff84b767ab8a801be1a)

0xedward on 25 May 2020

@0xedward sorry for not following up on this - there are a large number of notifications and sometimes things get lost ☹️

For this, we'd want something in in the hamburger menu. The Show Bookmarks Manager would be a good example to look at for implementation; Ctrl + Shift + B. There may be a complexity in catching the event in C++ and then sending a message (picked up in JavaScript) to disable shields

bsclifton on 20 Jul 2020

No problem, @bsclifton!

Thanks for the pointer! I'll continue working on it when I get the chance 🙂

0xedward on 21 Jul 2020

Hi,
If no one is working on this issue, can I pick it ?

Aadi-27 on 2 Oct 2020

👍1

I haven't gotten around to this yet, so feel free to take it over @Aadi-27

0xedward on 2 Oct 2020

👍1

Can someone help me with this ? I ran "npm run init" and it took around 3-4 hrs, used up 30+ gb of my data and still gave this error at the end. Now everytime I am running "npm run init", it throws this error.

errror part 1
errror part 2

Aadi-27 on 16 Oct 2020

@Aadi-27 did you follow dev setup README here?
https://github.com/brave/brave-browser/wiki/Windows-Development-Environment

bsclifton on 23 Oct 2020

I had the same problem on Linux today and I had to edit file brave-browser/src/brave/build/rustup/0.1.4/registry/src/github.com-1ecc6299db9ec823/semver-parser-0.10.1/src/generated.rs to remove the line #![rustfmt::skip] (on line 4, just delete the whole line) and then it built correctly. https://github.com/steveklabnik/semver-parser/issues/52