Brave-browser: Desktop :: Implement Custom Homepage

Created on 12 Feb 2020  路  2Comments  路  Source: brave/brave-browser

ODesktop OWindows OmacOS QA Pass-Win64 QA Pass-macOS QYes feature-request release-noteinclude

Most helpful comment

@anthonypkeane @LaurenWags
Suggested for release notes: Added support for referral background images and top sites on the new tab page

All 2 comments

@anthonypkeane @LaurenWags
Suggested for release notes: Added support for referral background images and top sites on the new tab page

Verified passed with

Brave | 1.8.85 Chromium: 81.0.4044.122聽(Official Build)聽(64-bit)
-- | --
Revision | 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS | macOS Version 10.14.6 (Build 18G3020)

  • Verified test plan from https://github.com/brave/brave-core/pull/4866

SR Install - see issues logged/noted below

  • Confirmed able to get Technikke images and top site tiles on each NTP opened
  • Confirmed SR component on brave://components
  • Confirmed promoCode in brave://local-state
  • Confirmed there is a new theme page at brave://settings/themes
  • Could not disable SR images on brave://settings/themes (See logged issue below)
    Screen Shot 2020-04-28 at 4 49 21 PM
    Screen Shot 2020-04-28 at 4 49 43 PM

Non-SR Install - PASSED

  • Confirmed new install without SR does not have brave://settings/themes page
  • Confirmed only standard NTP SI component is available, no SR component

Other scenarios:
1. User has default code/non SR code - PASSED
* Confirmed only standard NTP SI component is available, no SR component

  1. User has empty code (profile is over 90 days) - PASSED
  2. Confirmed only standard NTP SI component is available, no SR component

Logged issues

  • brave://settings/themes doesn't work, can't turn off SR images - logged https://github.com/brave/brave-browser/issues/9515

Verification passed on

Brave | 1.8.86 Chromium: 81.0.4044.129聽(Official Build)聽(64-bit)
-- | --
Revision | 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS | Windows聽10 OS Version 1803 (Build 17134.1006)
  • Verified test plan from https://github.com/brave/brave-core/pull/4866

Super Referral code install:

  • ensured that Technikke component loaded with a version in brave://components
  • ensured that promoCode is shown in the local-state file
  • ensured that 3 sets of Technikke images are shown in NTP's
  • ensured that pinned top tiles are shown by default in all NTP's
  • ensured that Theme option is added in brave://settings/themes
  • Encountered #9515
    image
    image

image
image
image
image

Non-Super Referral Install - PASSED

Confirmed new install without SR does not have brave://settings/themes page
Confirmed only standard NTP SI component is available, no SR component

Was this page helpful?
0 / 5 - 0 ratings