Brave-browser: "Safe Browsing" option in settings needs to be named "Google Safe Browsing"

[karenkliu]

Description

Currently the Safe Browsing option on the Settings page has a typo/bug; it's missing "Google" as part of the label.

Steps to Reproduce

1. Go to chrome://settings/privacy
2. See the typo in "Safe Browsing" title

Actual result:

Expected result:

It should have "Google" in the title - "Google Safe Browsing".

Reproduces how often:

easily reproduced on all channels

[karenkliu]

@tomlowenthal FYI

[bsclifton]

Should be an easy change; not a problem in Chrome because I don't think Safe Browsing can be disabled

[MatthewZito]

Hi, @bsclifton - I'm a big fan of Brave and believe this would be a good first issue for me to get started with contributing. Will you assign this to me?

I'm currently reading through all of your contribution guidelines to get up to speed. Thanks!

[bsclifton]

@MatthewZito awesome- issue assigned (thanks, @rebron 😄)

Once you get setup and have something building, you might just take a peek here:
https://github.com/brave/brave-core/blob/fd90db30af93e51387b312396d0d92484cdde47a/app/settings_strings.grdp#L2998-L3000

[MatthewZito]

@MatthewZito awesome- issue assigned (thanks, @rebron )

Once you get setup and have something building, you might just take a peek here:
https://github.com/brave/brave-core/blob/fd90db30af93e51387b312396d0d92484cdde47a/app/settings_strings.grdp#L2998-L3000

Great, thanks! I read through the docs - it looks like this PR will just be made against the brave-core repo's master branch...or should it be here?

[MatthewZito]

Thanks @rebron - PR opened. Please let me know if there's anything I should do differently next time ;D

[jofftiquez]

I'm curious. Why does it need to have the "Google" in it? Thanks.

[karenkliu]

cc @tomlowenthal ☝️

[rebron]

@jofftiquez We need to clarify that the Safe Browsing service is coming from Google and not a service created by Brave. https://safebrowsing.google.com/ The Safe Browsing service was put into Firefox originally and pre-dates Chrome and is used by other browsers as well.

@MatthewZito Thanks for the fix, this was great. Let's do it again!

[jofftiquez]

@rebron thanks, I understand now.

[GeetaSarvadnya]

Verification passed on

Brave | 1.7.67 Chromium: 80.0.3987.149 (Official Build) beta (64-bit)
-- | --
Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

• Verified the description from the issue
• Verified in both clean and upgraded profiles
  

Verification passed on

Brave | 1.7.70 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
-- | --
Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | Ubuntu 18.04 LTS

• Verified the description from the issue
  

Verified passed with

Brave | 1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
-- | --
Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | macOS Version 10.14.6 (Build 18G3020)

• Verified steps from description
  

• Encountered and logged https://github.com/brave/brave-browser/issues/8834