Brave-browser: entire a-c not going through due to missing delays
Description
The entire a-c amount not going through because it's being blocked server side due to missing delays.
Example:
- received
2.5 BATfrom ad grant - received
17.5 BATfrom UGP grant - Total BAT:
20 BAT - a-c setup as
Up to 15 BATviabrave://settings
Only 8 BAT went through rather than the 15 BAT
Created issues for iOS & Android:
- iOS - https://github.com/brave/brave-ios/issues/2200
- Android - https://github.com/brave/browser-android-tabs/issues/2442
Steps to Reproduce
Case #1
- launch Brave using
--enable-logging=stderr --rewards=staging=true,reconcile-interval=5 - set
Monthly Paymentto10 BAT(should be already selected as the default) - accept the UGP grant
- spend ~1.5mins on https://duckduckgo.com/ and ensure it's being displayed in the a-c table
- spend ~1.5mins on https://laurenwags.github.io/ and ensure it's being displayed in the a-c table
- spend ~1.5mins on https://yachtcaptain23.github.io and ensure it's being displayed in the a-c table
- ensure that a-c goes through and the correct amount is deducted from the total
- ensured that the correct amount of BAT has been deducted from Brave
Case #2
Actual result:
Using UGP without any ad grants:
Using UGP without any ad grants:
Expected result:
If the user has the required funds, the entire a-c should go through.
Reproduces how often:
100% reproducible using the above STR.
Brave version (brave://version info)
Brave | 1.5.27 Chromium: 79.0.3945.117 (Official Build) nightly (64-bit)
--- | ---
Revision | 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS | macOS Version 10.15.2 (Build 19C57
Brave | 1.3.89 Chromium: 79.0.3945.117聽(Official Build)聽beta聽(64-bit)
-- | --
Revision | 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS | macOS Version 10.15.2 (Build 19C57)
Version/Channel Information:
- Can you reproduce this issue with the current release?
Couldn't reproduce with 1.2.42 CR: 79.0.3945.117 - Can you reproduce this issue with the beta channel?
Yes - Can you reproduce this issue with the dev channel?
Yes - Can you reproduce this issue with the nightly channel?
Yes
Other Additional Information:
- Does the issue resolve itself when disabling Brave Shields?
N/A - Does the issue resolve itself when disabling Brave Rewards?
N/A - Is the issue reproducible on the latest version of Chrome?
N/A
Miscellaneous Information:
CCing @brave/legacy_qa @evq @NejcZdovc @rebron @mandar-brave
kjozwiak
All 10 comments
Labeling as release/blocking for now till @evq and @NejcZdovc investigate.
kjozwiak
on 13 Jan 2020
This should also be checked in with a monthly tip (monthly contribution) - so have a monthly tip set up along with AC. So something like:
- launch Brave using
--enable-logging=stderr --rewards=staging=true,reconcile-interval=5 - set
Monthly Paymentto10 BAT(should be already selected as the default) - accept the UGP grant
- set up a monthly tip for a site like 3zsistemi.si, confirm it is shown on Monthly Contributions panel on brave://rewards
- spend ~1min on https://duckduckgo.com/ and ensure it's being displayed in the a-c table
- spend ~1min on https://laurenwags.github.io/ and ensure it's being displayed in the a-c table
- spend ~1min on https://yachtcaptain23.github.io and ensure it's being displayed in the a-c table
- ensure monthly tip goes thru and correct amount is deducted from the total
- ensure that a-c goes through and the correct amount is deducted from the total
LaurenWags
on 13 Jan 2020
@GeetaSarvadnya also ran into the following scenario, which sounds related to this issue and should be retested once this issue is resolved:
- Clean profile with 1.2.x, launch with staging parameters & quick reconcile
- Set up data for AC, but before AC occurs upgrade to 1.3.x
--> After upgrade AC is not occurring but wallet balance is being reduced
@GeetaSarvadnya please update this scenario with any additional relevant details so we can retest once this issue is resolved 馃憤
LaurenWags
on 14 Jan 2020
AC and monthly Tip values are not reflected in Panel/Summary/NTP widget after the auto contribution
Case 1:
- Clean profile 1.2.39 - launch brave with staging flag and with reconcile interval
- Claim UGP grants
- Set monthly Tip for https://duckduckgo.com/
- Send a one-time tip to https://duckduckgo.com/
- Before the auto contribution upgrade profile to 1.3.91
- Wait until auto contribution completes
Actual:
- AC is going through and correct balance is getting deducted but it's not shown in panel or summary or NTP widget
- Monthly tip is processing and the correct amount is deducted but the monthly tip isn't shown in panel or summary or NTP widget
- There is no AC notification
- AC table is getting cleared only after brave://rewards page reload
Case 2:
- Clean profile 0.71.104 launch brave with staging flag with short reconcile interval
- Claim UGP grants
- Set monthly Tip for https://duckduckgo.com/
- Send a one-time tip to https://duckduckgo.com/
- Trigger auto contribution and ensured AC amount is reflected in panel and summary
- Upgrade 1.3.91
- Add https://duckduckgo.com/ to auto contribution table
- Trigger auto contribution
Actual:
- AC is going through and correct balance is getting deducted but it's not shown in panel or summary or NTP widget
- Monthly tip is processing and the correct amount is deducted but the monthly tip isn't shown in panel or summary or NTP widget
- There is no AC notification
GeetaSarvadnya
on 14 Jan 2020
reproduced https://github.com/brave/brave-browser/issues/7709#issuecomment-574223737 on macOS
Brave | 1.3.91 Chromium: 79.0.3945.117聽(Official Build)聽beta聽(64-bit)
-- | --
Revision | 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS | macOS Version 10.14.6 (Build 18G103)
@NejcZdovc will the fix for this issue also address @GeetaSarvadnya finding that the summary (panel and on brave://rewards) is not reflecting the Auto-Contribute and Monthly Contribution amounts? For example, in the below image, the AC and Monthly Contribution amounts were from 1.2.39. When I upgraded to 1.3.91 and AC occurred again, the AC and Monthly Contribution amounts should have increased (5--> 10 and 1--> 2), however they did not.
Please let us know if this should be logged separately.
cc @kjozwiak
LaurenWags
on 14 Jan 2020
@LaurenWags if I understand correctly just UI is not updated, but everything else works as expected?
NejcZdovc
on 14 Jan 2020
could be this issue https://github.com/brave/brave-browser/issues/7526?
NejcZdovc
on 14 Jan 2020
I think so. will add comment on that issue as well. thanks @NejcZdovc !
LaurenWags
on 14 Jan 2020
One-time tips are not shown in the Tips panel.
Case 1: https://github.com/brave/brave-browser/issues/7608#issuecomment-571646553
Case 2: Please note this case is intermittent but 80% is a reproducible rate
- Clean profile 1.3.94 - launch Brave using --enable-logging=stderr --rewards=staging=true
- Restore Ads grants
- Claim Ads grants
- Claim UGP grants
- Open https://duckduckgo.com/
- Send a one-time tip of 1 BAT to DDG
- One-time is not displayed under Tips panel, Tips panel is empty, reload brave://rewards multiple times didn't help
GeetaSarvadnya
on 20 Jan 2020
Verified passed with
Brave | 1.3.108 Chromium: 79.0.3945.130聽(Official Build)聽beta聽(64-bit)
-- | --
Revision | e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS | macOS Version 10.14.6 (Build 18G103)
- Verified test plans from https://github.com/brave/brave-core/pull/4372
Test Plan 1:
Test Plan 2:
Verified Case 1 from description:
Verified Case 2 from description:
Verified example from description:
Additional testing notes can be found here:
- https://github.com/brave/brave-browser/issues/6078#issuecomment-580958330
- https://github.com/brave/brave-browser/issues/6942#issuecomment-580930621
- https://github.com/brave/brave-browser/issues/7526#issuecomment-580931129
Verification passed on
Brave | 1.3.109 Chromium: 79.0.3945.130聽(Official Build)聽beta聽(64-bit)
-- | --
Revision | e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS | Windows聽10 OS Version 1803 (Build 17134.1006)
Verified the test plan from
Plan 1:
Plan 2:
Logged #8041
Verified Case 1 from the description
- Verified Case 2 from description
Encountered #8019
Verified the cases from https://github.com/brave/brave-browser/issues/7709#issuecomment-574223737
Verification passed on
Brave | 1.3.110 Chromium: 80.0.3987.78聽(Official Build)聽(64-bit)
-- | --
Revision | cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS | Ubuntu 18.04 LTS
- Verified test plans from https://github.com/brave/brave-core/pull/4372
Test Plan 1:
Test Plan 2:
Also verified test plan from the description.
LaurenWags
on 3 Feb 2020
Related issues
pitsi
路
3Comments
moritzhaller
路
3Comments
bsclifton
路
3Comments
traffisco
路
3Comments
hollons
路
3Comments