Brave-browser: Linux GTK+ Dark makes low contrast in menu

[AlexeyBarabash]

Description

From certain point I see low contrast text in menus with my old settings Brave colors: Dark; Themes: GTK+ on Ubuntu 16

Steps to Reproduce

1. Take Ubuntu 16, install Brave Beta/Dev/Nightly
2. Setup the settings like
   

Actual result:

1. Click menu button in top-right corner, see
   
   The same is for the context menu
   

Expected result:

1. On Stable version this gives
   

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.4.5 Chromium: 79.0.3945.56 (Official Build) nightly (64-bit)
-- | --
Revision | 73cc6bf591f792b99f8fc7cdfb8addedbd084bf8-refs/branch-heads/3945@{#788}
OS | Linux

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the dev channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

With Dark+Classic all is good

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

CC @petemill

[btlechowski]

Reproduced on Ubuntu 18.04 LTS. This is reproducible with GTK+ theme and not with default Classic theme

Brave | 1.1.20 Chromium: 79.0.3945.74 (Official Build) (64-bit)
-- | --
Revision | 99b6d241cf84f7fa7434ae8a59f9e74eb1464280-refs/branch-heads/3945@{#888}
OS | Ubuntu 18.04 LTS

Not reproducible on

Brave | 1.0.1 Chromium: 78.0.3904.108 (Official Build) (64-bit)
-- | --
Revision | 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS | Ubuntu 18.04 LTS

cc @rebron @brave/legacy_qa

[srirambv]

Pretty sure this is Unity related issue. No such issue with Ubuntu 19.04

Brave | 1.0.1 Chromium: 78.0.3904.108 (Official Build) (64-bit)
-- | --
Revision | 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS | Linux

This is with Default Appearance on Tweaks as well

Doesn't reproduced on 1.1.20

[eldk]

Hello,

https://community.brave.com/t/linux-update-gives-unreadable-menus-black-on-black/98141

https://community.brave.com/t/gtk-theme-context-menus-dark-1-1-20-1-1-21/98413

It was OK with Brave 1.0.1 but not with 1.1.20.

Chrome/ium 79.n are OK, GTK theme is not broken.

https://chromium.googlesource.com/chromium/src/+/master/chrome/browser/themes/theme_service.cc#601

https://github.com/brave/brave-core/blob/9e7f5047afd7fdbb25aa884005918382f381578d/browser/themes/brave_theme_service.cc#L247

Thanks,

Eric

[timolson]

From a user perspective, this problem makes Brave unusable. Please prioritize. Comment written using Firefox -_-

I experience this problem in:
Version 1.1.22 Chromium: 79.0.3945.79 (Official Build) (64-bit)
Ubuntu 18.04.3 LTS

Wait... priority 4? Really? On my screen you can't really see any contrast in the menus, making all menus, and the browser itself, completely unusable.

[rebron]

cc: @simonhong Can you take a look?

[simonhong]

@rebron Ok
I confirmed that this doesn't happen on my local with GNOME Shell (Ubuntu 19.04)
I can repro this on my local vm with GNOME Shell (Ubuntu 18.04)

[Nicolab]

Thanks @simonhong
Do you know when there will be an update fixing this issue in the stable release?

[simonhong]

@Nicolab If the fix(https://github.com/brave/brave-core/pull/4261) is merged only 1.4 nightly, February 25, 2020 is the 1.4 stable target release date.
If we uplift this to current beta(1.2 or 1.3), you can get this more quickly.
(FYI, our release schedule - @https://github.com/brave/brave-browser/wiki/Brave-Release-Schedule)
Do we want uplifting this? @rebron

[Nicolab]

Ok thank you @simonhong

[rebron]

@simonhong Yes, can you create uplifts for 1.2 and 1.3.
@Nicolab 1.2 in release is targeted for week of January 6th.

[Nicolab]

Great! Thanks @rebron

[btlechowski]

Verification passed on

Brave | 1.2.40 Chromium: 79.0.3945.88 (Official Build) (64-bit)
-- | --
Revision | c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS | Ubuntu 18.04 LTS

Verified test plan from https://github.com/brave/brave-core/pull/4261

https://github.com/brave/brave-core/pull/4261

[timolson]

The "Save Password" dialog is still suffering this issue.