Brave-browser: Twitter tips button needs proper spacing

Created on 12 Oct 2019  路  8Comments  路  Source: brave/brave-browser

Description

Twitter Tips button is too close to the share button and needs proper spacing/padding.

Actual result:

Screen Shot 2019-10-11 at 11 52 47 PM

Expected result:

61867921-e8f37280-aef5-11e9-8e2c-79c5ce4c9a37

See: https://github.com/brave/brave-browser/issues/4548

Reproduces how often:

This reproduces easily in 0.69.135.

  1. Login to Twitter
  2. Ensure Brave Rewards is on.
  3. Notice Twitter Tips button placement.

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes
QA Pass-Linux QA Pass-Win64 QA Pass-macOS QTest-Plan-Specified QYes bug featurrewards prioritP2 release-noteinclude

All 8 comments

Hey @rebron I can do it!! 馃憤

Looks like this is also reproducible using 0.67.123 CR: 76.0.3809.87 which means Twitter must have changed something in their end which is causing the problem. Seems to be happening when you're logged into Twitter.

Example while being logged in:

Screen Shot 2019-10-12 at 11 43 12 AM

Example while being logged out:

Screen Shot 2019-10-12 at 11 43 43 AM

It would be excellent if the twitter tip button could be turned on and off. I'm happy to try out BAT, but I cannot stand the button so I had to opt out of BAT.

Possible dupe of #4562

@brimwats you actually can turn it off on a per-publisher basis:

  1. Navigate to brave://rewards/
  2. Click the Tip Settings button
    Screen Shot 2019-10-13 at 10 38 40 PM
  3. Uncheck the types that you don't want to see (or uncheck them all!)
    Screen Shot 2019-10-13 at 10 39 51 PM

@alexandriaroberts you're definitely welcome to grab this! 馃槃 I've been putting together a contributor guide (not merged yet) which has some tips for getting started:
https://github.com/brave/brave-browser/pull/6265
(comments extremely welcomed!)

Once you get setup and have things building, editing the rewards parts shouldn't be too hard
cc: @ryanml

Hey @bsclifton , Yes, I would love too!! Thank you! I will set my laptop up and will start working on it. Thank you.馃榾 If I have any questions I will message here! 馃槉

Verification passed on

Brave | 0.71.108 Chromium: 78.0.3904.87聽(Official Build)聽beta聽(64-bit)
-- | --
Revision | 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS | Windows聽10 OS Version 1803 (Build 17134.1006)

  • Verified the STR from the description
    image
    image

Verification passed on

Brave | 0.71.111 Chromium: 78.0.3904.87聽(Official Build)聽(64-bit)
-- | --
Revision | 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS | Ubuntu 18.04 LTS

  • Verified the STR from the description
    image
    image

Verified passed with

Brave | 0.71.111 Chromium: 78.0.3904.87聽(Official Build)聽(64-bit)
-- | --
Revision | 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS | macOS Version 10.13.6 (Build 17G5019)

  • Verified STR from description
  • Verified tip button appears spaced correctly for tweets in my feed:
    Screen Shot 2019-11-04 at 3 48 37 PM

  • Verified tip button appears spaced correctly for my own tweets (when logged in):
    Screen Shot 2019-11-04 at 3 49 19 PM

Was this page helpful?
0 / 5 - 0 ratings