Brave-browser: Developer tool doesn't load with remote devices in brave-browser (Desktop)

[GeetaSarvadnya]

Test plan

See https://github.com/brave/brave-core/pull/4044

Description

Developer tool doesn't load with remote devices in brave-browser (Desktop). Verified couple of brave versions, the issue persists on all the versions including latest released version.

0.67.125 - Dev tool doesn't load with remote devices
0.66.101 - Dev tool doesn't load with remote devices
0.65.121 - Dev tool doesn't load with remote devices

Steps to Reproduce

1. Clean or upgraded profile
2. Connect Android device to Desktop
3. Open brave://inspect#devices in Desktop
4. Visit a site on brave Android
5. Ensure the site lists on brave://inspect#devices
6. Click on inspect under the device name in desktop
7. Developer tool window launches but never loads

Actual result:

Developer tool window launches but never loads

Expected result:

Should load developer tool with remote devices

Reproduces how often:

Always

Brave version (brave://version info)

All brave versions

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the dev channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@brave/legacy_qa

[bsclifton]

@GeetaSarvadnya this may be intentional

@pilgrim-brave would this be happening because remote debugging was disabled with https://github.com/brave/brave-browser/issues/1736 ?

[pilgrim-brave]

Very likely.

[GeetaSarvadnya]

Click on inspect fallback opens up devtool.

[rebron]

We want to re-enable this by proxy. Does this sound ok? @diracdeltas
cc: @jumde

[eljuno]

+1 from Community https://community.brave.com/t/brave-remote-debugging-is-not-working/83109?u=eljuno

[gokujy]

How to Clean or upgraded profile?????

[TheBird956]

Any idea when we can get this feature back? Removing this is an absolute dealbreaker for most developers (including myself).

I feel like this was disabled for no good reason. At least let us decide if we want to download an extra package from Google but have it disabled by default.

[bsclifton]

@jumde this would be a great one for you to check out, when you have cycles 😄 (noticed you had already self-assigned). I think the big problem was that files are being fetched remotely. We can likely proxy those... and/or we could put this feature behind a flag

PR that disabled this: https://github.com/brave/brave-core/pull/790

[neuronetio]

Please re-enable remote debug :cry:

[diracdeltas]

@rebron i think we should re-enable this with proxy (sorry for the delay)

[diracdeltas]

actually enabling behind a flag would be fine if this is easier

[nicholasengleman]

I am a developer and will be switching back to chrome till there is a way for me to re-enable this. This breaks the Lighthouse Audit for me and who knows what else. I had previously been recommending Brave to other developers but not anymore. When I'm developing, I can't risk any issues coming from my tools and making debugging even more complicated.

[nicholasengleman]

This is an absolute deal breaker for any developer. Will be moving back to chrome and not recommending brave to any more developers till we can re-enable this.

[salmankhilji]

+1. Please bring this feature back.

[bsclifton]

Taking a look at this now... I believe we'll be able to add a config flag for this (defaulted to OFF) which allows you to opt-in to the feature. I can make sure a clear log happens in case it's disabled (to make it more obvious). We'll need to have this go through security review too

[bsclifton]

Fixed! Will be in our next Nightly (1.3, which is due to ship Feb 4th). We may uplift to 1.2 (Dev, shipping Jan 6th) if there's enough support for it and if no problems are discovered 😄

[salmankhilji]

I confirm that this works with Nightly 1.33.3 against a WebView running in React Native on a Nexus 6P device.

Thank you!

[LaurenWags]

Adding QA/Blocked label per https://github.com/brave/brave-browser/issues/3199#issuecomment-567045246

[bsclifton]

Fixed in 1.2; waiting for a new BETA build before it can be tested again

[btlechowski]

Should be fixed in 1.2.30.

[btlechowski]

Verification passed on

Brave | 1.2.30 Chromium: 79.0.3945.79 (Official Build) beta (64-bit)
-- | --
Revision | 29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{#916}
OS | Ubuntu 18.04 LTS

Verified using test plan from brave/brave-core#4044 for this issue.

Verification passed on

Brave | 1.2.37 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
-- | --
Revision | c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

• Verified using test plan from brave/brave-core#4044 for this issue.
  

Verified passed with

Brave | 1.2.40 Chromium: 79.0.3945.88 (Official Build) (64-bit)
-- | --
Revision | c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS | macOS Version 10.14.6 (Build 18G103)

• Verified test plan from https://github.com/brave/brave-core/pull/4044

Before enabling Remote Debugging:

After enabling Remote Debugging: