Brave-browser: Can't Access Extension Keyboard Shortcuts

[jonathansampson]

Test plan

See https://github.com/brave/brave-core/pull/4796

Description

Updates to about:settings prevents users from having easy access to Extension Shortcuts. Users can still manually navigate there by visiting brave://extensions/shortcuts.

Reported by _Agent of User_ on Twitter:

Steps to Reproduce

1. Navigate to about:extensions
2. Click to view Extension shortcuts

Actual result:

No link exists.

Expected result:

Link should exist.

Reproduces how often:

100%

Brave version (brave://version info)

0.65.16

Reproducible on current release:

No. Reproducible on current Beta, Developer, and Nightly.

Additional Information

[rebron]

Related: https://github.com/brave/brave-browser/issues/3771

[qnxor]

I came to create an issue about this. Not sure why this was removed. I'm very dependent on it, e.g. for invoking my global password manager. Do please bring it back :)

Is there a way at all to set shortcuts for extensions currently, even if hacky? Where are they stored?

[agentofuser]

@qnxor yeah I miss it too. For now you can navigate directly to it by entering brave://extensions/shortcuts in the address bar.

[aleqx]

I wanted to chip in myself so +1

Thanks for pointing to brave://extensions/shortcuts - I wasn't aware.

However, there is at least one bug (i should report it separately I guess). I can't set Ctrl+/ as a shortcut, whereas on Chrome I can.

EDIT: Strike that last part, I can't set Ctrl+/ on Chrome either

[bsclifton]

Interesting- we may be unintentionally hiding this. Thanks for the heads up 😄

[megaroeny]

Glad someone else reported this. Was bugging the heck outta me! 😆
@bsclifton did you discover if you were intentionally hiding this or not?

[Brave-Matt]

+1 https://community.brave.com/t/brave-has-removed-menu-shortcut-to-extension-keyboard-shortcuts-menu-give-it-back/56840?u=mattches

[Brave-Matt]

+1 https://community.brave.com/t/brave-has-removed-menu-shortcut-to-extension-keyboard-shortcuts-menu-give-it-back/56840/3?u=mattches

[Brave-Matt]

+1 https://community.brave.com/t/brave-has-removed-menu-shortcut-to-extension-keyboard-shortcuts-menu-give-it-back/56840/6?u=mattches

[rebron]

@jaminroe Unintentional.

Can still manually get to it via: brave://extensions/shortcuts
In interim we can probably get that link in there without having to do a full sidebar implementation. Possibly a link to Keyboard Shortcuts just under the "Find extensions and themes in the Web store" link.

[pauleil]

+1

[Annihilannic]

I thought I was going insane, can't even find it by searching Brave settings, eventually discovered the "power user" link on the QuickTabs settings page, but shouldn't have to find it that way.

[btlechowski]

Verification passed on

Brave | 1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
-- | --
Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | Ubuntu 18.04 LTS

Verified test plan from https://github.com/brave/brave-core/pull/4796
brave://settings/extensions

brave://extensions/shortcuts

Verified assigning shortcut works

Verified shortcut works

Verification PASSED on macOS 10.15.3 x64 Catalina using the following build:

• ensured that Keyboard shortcuts is visible under brave://settings/extensions
• ensured Keyboard shortcuts opens brave://extensions/shortcuts when there's no extension
• ensured Keyboard shortcuts opens brave://extensions/shortcuts if there's an extension
• ensured typing brave://extensions/shortcuts into the URL bar worked without issues
• ensured that setting a shortcut works without any issues via brave://extensions/shortcuts
  ** ensured it works with multiple extensions at the same time

Example when there's no extensions installed

Setting under brave://extensions

Multiple extensions

Verification passed on

Brave | 1.7.78 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
-- | --
Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

• ensured that Keyboard shortcuts is visible under brave://settings/extensions
• ensured Keyboard shortcuts opens brave://extensions/shortcuts when there's no extension
• ensured Keyboard shortcuts opens brave://extensions/shortcuts if there's an extension
• ensured typing brave://extensions/shortcuts into the URL bar worked without issues
• ensured that setting a shortcut works without any issues via brave://extensions/shortcuts
  ** ensured it works with multiple extensions at the same time

Example when there's no extensions installed

Setting under brave://extensions

Multiple extensions